fix(Other): Zephyr: MAX32660: add compat wrappers #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsm
force-pushed
the
fix_max32660_defines
branch
from
4f0e4c2 to
82dad15
Compare
mattsm
changed the title
mattsm
force-pushed
the
fix_max32660_defines
branch
from
82dad15 to
a7cd270
Compare
MaureenHelm
approved these changes
Feb 5, 2025
Some defines and structs are different so reconcile these here Signed-off-by: Matthew McClintock <[email protected]>
mattsm
force-pushed
the
fix_max32660_defines
branch
from
a7cd270 to
0a34a87
Compare
|
I have similar kind of PR for MAX32650 at #1337. The reviewers said that do not use MXC type macro on wrapper files. Use ADI macro if you can or change the macro file directly at *_regs.h (e.g uart_regs.h). Please review the other PR. If MXC type macro is used directly at zephyr drivers (and the board doesnt have that macro), replace the MXC macro with ADI macro on zephyr drivers and add to the wrapper file. |
yasinustunerg
suggested changes
Feb 7, 2025
| ${MSDK_PERIPH_SRC_DIR}/FLC | ||
| ${MSDK_PERIPH_SRC_DIR}/GPIO | ||
| ${MSDK_PERIPH_SRC_DIR}/I2C | ||
| ${MSDK_PERIPH_SRC_DIR}/I2S |
There was a problem hiding this comment.
Suggested change
| ${MSDK_PERIPH_SRC_DIR}/I2S | |
| ${MSDK_PERIPH_SRC_DIR}/SPIMSS |
| if (CONFIG_I2S_MAX32) | ||
| zephyr_library_sources( | ||
| ${MSDK_PERIPH_SRC_DIR}/I2S/i2s_me11.c | ||
| ${MSDK_PERIPH_SRC_DIR}/I2S/i2s_reva.c |
There was a problem hiding this comment.
Suggested change
| ${MSDK_PERIPH_SRC_DIR}/I2S/i2s_reva.c | |
| ${MSDK_PERIPH_SRC_DIR}/SPIMSS/i2s_reva.c |
|
|
||
| if (CONFIG_I2S_MAX32) | ||
| zephyr_library_sources( | ||
| ${MSDK_PERIPH_SRC_DIR}/I2S/i2s_me11.c |
There was a problem hiding this comment.
Suggested change
| ${MSDK_PERIPH_SRC_DIR}/I2S/i2s_me11.c | |
| ${MSDK_PERIPH_SRC_DIR}/SPIMSS/i2s_me11.c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some defines and structs are different so reconcile these here