Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam release? #2

Open
phated opened this issue Apr 23, 2019 · 5 comments
Open

opam release? #2

phated opened this issue Apr 23, 2019 · 5 comments

Comments

@phated
Copy link
Collaborator

phated commented Apr 23, 2019

Hey @andreas, this project is great! Is there anything missing before it gets an opam release?

@andreas
Copy link
Owner

andreas commented Apr 23, 2019

Honestly I've found myself spread too thin, so I haven't found time to give the project much love 😬
Would you be interested in getting commit rights?

@phated
Copy link
Collaborator Author

phated commented Apr 24, 2019

@andreas totally understandable! I'm still new to the ocaml side of things (coming from reason) but I would love to help out where I can. I'm currently working on some example code using this library with ocaml-graphql-server and it's working great.

@andreas
Copy link
Owner

andreas commented Apr 24, 2019

That makes sense. I think this repo might be a good way to cut your teeth -- it's fairly small and self-contained, but still presents an opportunity to get experience with the entire flow of developing a package 😄 I've invited you as a collaborator now if you feel like it.

My suggested steps to a release would be:

  1. Update from jbuilder to dune
  2. Update to OPAM2 (this should fix Travis)
  3. Get a green build on Travis (hopefully requires no work after step 2)
  4. Publish

@selasiehanson
Copy link

selasiehanson commented Oct 19, 2019

@andreas great project! I'm not sure if @phated is still working on getting this but I managed to promote the project to dune and got travis to build as well. I'm also new to Ocaml as well 😄.
If it's okay with you guys I can open a pr against this repo. My fork is located at https://github.com/selasiehanson/ocaml-dataloader

@andreas
Copy link
Owner

andreas commented Oct 19, 2019

@selasiehanson, sounds great. Please go ahead with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants