Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Lady MC countdown bugs #27

Open
Zidras opened this issue Sep 5, 2020 · 2 comments
Open

Lady MC countdown bugs #27

Zidras opened this issue Sep 5, 2020 · 2 comments

Comments

@Zidras
Copy link
Contributor

Zidras commented Sep 5, 2020

Those functions need work.

  1. Double countdown
  2. Wrong countdown compared to timer
  3. Keeps counting after fight is over
@Barsoomx
Copy link
Contributor

Barsoomx commented Sep 5, 2020

I made a soundPrototype for 5->1 countdowns,

Wrong countdown is because it uses spell_aura_applied and is fired approx 0.5 seconds after the last target has been mc'd. I fixed that too in my fork.

Not sure how to cancel events on combat end, I can just cancel those OnCombatEnd()

Is there a warmane PTR? not sure how to test it outside of my test server(spell cast success targets? emote?)

I'll make a pull request tomorrow

@Zidras
Copy link
Contributor Author

Zidras commented Sep 6, 2020

Sadly, no PTR. Even etracing would be almost impossible to see on stream due to event spam (idk a way to log events for later inspection on this xpac).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants