Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "Empty" field optional #55

Closed
truegoodwill opened this issue Feb 23, 2022 · 2 comments · Fixed by #117
Closed

Make the "Empty" field optional #55

truegoodwill opened this issue Feb 23, 2022 · 2 comments · Fixed by #117

Comments

@truegoodwill
Copy link

truegoodwill commented Feb 23, 2022

I had a bunch of public static readonly instances defined, and used reflection to bundle them all up into a readonly list at startup. The Empty value crept into that list by accident. I have other ways of fixing that little issue, but I thought maybe it would be a good idea to be able to suppress the Empty if someone needs to.

And since this is my first time communicating with you ... thank you Andrew, Great job :)

@andrewlock
Copy link
Owner

Thanks, appreciate it. I'm a little undecided on this one. There's already quite a lot of configuration options, and no doubt will be more added later. I'm not sure if the extra option is worth it in this case 🤔

@andrewlock
Copy link
Owner

I think I've found an answer to this in the big redesign of the library in this PR:

The main idea is to make the library much more maintainable while also giving people a mechanism to customise the generated IDs as much as they like. This will make it easy to make changes like this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants