Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about the setting of validation dataset #20

Open
YwSama opened this issue May 19, 2023 · 2 comments
Open

Confusion about the setting of validation dataset #20

YwSama opened this issue May 19, 2023 · 2 comments

Comments

@YwSama
Copy link

YwSama commented May 19, 2023

Thank you for your great work. I retrained the model according to the code in README. But I founded the default value of "--val_dataset" is "test" in line 12, utils/options.py. Will it affect the results?

@anosorae
Copy link
Owner

This setting follows the prior works.

@shujielan
Copy link

This setting follows the prior works.

Sorry, can you elaborate on this continuation of the 'piror works'? I also noticed this. Do you mean: when training, it is set to 'val'. When debugging the test.py file, I found that the ‘training’ and ‘val_dataset’ of args are defined to false and test. So the setting about 'val_dataset' is ‘val’ during training process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants