Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe an error in the original paper? #33

Open
ThomasjonLi opened this issue Dec 4, 2023 · 1 comment
Open

Maybe an error in the original paper? #33

ThomasjonLi opened this issue Dec 4, 2023 · 1 comment

Comments

@ThomasjonLi
Copy link

ThomasjonLi commented Dec 4, 2023

In the paper, the calculation of IRR loss made me confused,
image
We can treat this as an CE loss. |M| can be treat as the batch size, |V| can be treat as the class num. As $y^i$ is one-hot,so only single $y^i_j$ is set to 1 and others are 0. Thus the loss should not be divided by |V|.

@mikanatsumi
Copy link

This is not an error. In the code itself they have used simple CE loss by pytorch. They have just written it like this intentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants