Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong mount partition for RHEL-08-040132, RHEL-08-040133 and RHEL-08-040134 #312

Open
moncapitain opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@moncapitain
Copy link

Describe the Issue
In fix-cat2.yml in the ansible play block for RHEL-08-040132, RHEL-08-040133 and RHEL-08-040134 the item.mount == '/var/log/audit' is set to the wrong partition, it should be /var/tmp since the stigs are calling for adding the mount options to /var/tmp.

Expected Behavior
The item mount entry should be item.mount == '/var/tmp' instead.

Actual Behavior
Right now nodev, nosuid and noexec are attempted to be applied twice because the ansible block for stigs RHEL-08-040132, RHEL-08-040133 and RHEL-08-040134 is being applied to /var/log/audit which already has it's own set of stigs to apply those options.

Control(s) Affected
Because of this issue nodev, nosuid and noexec are never applied to /var/tmp

Environment (please complete the following information):

  • branch being used: [main]
  • Ansible Version: [ 2.16.3]
  • Host Python Version: [Python 3.12.3]
  • Ansible Server Python Version: [Python 3.12.3]
  • Additional Details:

Additional Notes
It would be best to separate the block of ansible play for RHEL-08-040132, RHEL-08-040133 and RHEL-08-040134 for individual plays so that one can choose to disable or leave enable the individual mount options.

Possible Solution
update the block code to item.mount == '/var/tmp'

@moncapitain moncapitain added the bug Something isn't working label Nov 14, 2024
uk-bolly added a commit that referenced this issue Nov 14, 2024
@uk-bolly uk-bolly self-assigned this Nov 14, 2024
@uk-bolly
Copy link
Member

hi @moncapitain

Thank you for the issue, this is a brilliant catch. I have pushed up a PR to resolve the core issue to go to devel. Its normally a couple of weeks before we push to main.

Many thanks

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants