Update chatbot image when RAG image is updated #61
Conversation
TamiTakamiya
force-pushed
the
TamiTakamiya/AAP-37207/trigger-chatbot-service-build-when-rag-image-updated
branch
2 times, most recently
from
7ab60d2 to
536ccba
Compare
TamiTakamiya
force-pushed
the
TamiTakamiya/AAP-37207/trigger-chatbot-service-build-when-rag-image-updated
branch
2 times, most recently
from
3f2aa5e to
fb228d0
Compare
TamiTakamiya
force-pushed
the
TamiTakamiya/AAP-37207/trigger-chatbot-service-build-when-rag-image-updated
branch
from
fb228d0 to
a629eb6
Compare
| - IMAGE_TAGS=pr-{{pull_request_number}} pr-{{pull_request_number}}.$(tasks.git-metadata.results.commit-timestamp) | ||
| - GIT_COMMIT=$(tasks.clone-repository.results.commit) | ||
| - RAG_CONTENTS_SUB_FOLDER=vector_db/aap_product_docs | ||
| - LIGHTSPEED_RAG_CONTENT_IMAGE=quay.io/ansible/aap-rag-content:1.0.1739753069 |
There was a problem hiding this comment.
This is for re-writing BUILD_ARGS in YAML list syntax and specifying a semver version to aap-rag-content image
| - IMAGE_TAGS=latest 1.0.$(tasks.git-metadata.results.commit-timestamp) | ||
| - GIT_COMMIT=$(tasks.clone-repository.results.commit) | ||
| - RAG_CONTENTS_SUB_FOLDER=vector_db/aap_product_docs | ||
| - LIGHTSPEED_RAG_CONTENT_IMAGE=quay.io/ansible/aap-rag-content:1.0.1739753069 |
There was a problem hiding this comment.
Same changes added to the push.yaml as well.
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
I used my private GitHub repositories (and corresponding Konflux builds/quay.io repos) for test:
There was a problem hiding this comment.
no I meant how can I test this renovate config itself? should I use Renovate CLI?
There was a problem hiding this comment.
According to Slack posts like this, renovate, which checks updates of the image, runs every 4 hour. So there might be delays up to 4 hours.
Oh ok just saw your comment on Slack
There was a problem hiding this comment.
Just one small thing which is not a blocker:
Maybe we can enforce testing the renovate stuff with the CLI instead of waiting Konflux to run it. So we can do our own verification upfront so we can make sure Konflux doesnt fail because of this. WDYT?
There was a problem hiding this comment.
Maybe we can enforce testing the renovate stuff with the CLI instead of waiting Konflux to run it.
I do not know how to trigger renovate with CLI and that's why I wrote my private repos for testing... How can we test renovate with CLI?
There was a problem hiding this comment.
Probably we can install this and use this locally at least or make the pre-commit run it in the future to validate the config json https://docs.renovatebot.com/getting-started/running/#npm-package-cli
There was a problem hiding this comment.
I will take a look at it once I have time
TamiTakamiya
deleted the
TamiTakamiya/AAP-37207/trigger-chatbot-service-build-when-rag-image-updated
branch
Description
For AAP-37207.
Trigger chatbot service image build when RAG content image is updated using renovate (reference)
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing