feat: creating branch from tagged branch #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
the
enhancement
klmcadams
reviewed
Oct 3, 2024
doc-deploy-changelog/action.yml
Outdated
| @@ -262,7 +262,7 @@ runs: | |||
| if [ $count -gt 0 ]; then | |||
| echo "Using ${{ env.UPDATE_BRANCH }} to update the CHANGELOG file" | |||
| if [[ ${{ env.RELEASE_BRANCH_EXISTS }} == "false" ]]; then | |||
| git checkout -b ${{ env.UPDATE_BRANCH }} | |||
| git checkout -b ${{ env.UPDATE_BRANCH }} ${{ env.MAIN_BRANCH }} | |||
There was a problem hiding this comment.
I think we should keep it as git checkout -b ${{ env.UPDATE_BRANCH }} because the temporary branch, maint/changelog-update-v${{ env.TAG_VERSION }}, is only created if the release branch or main do not exist. Otherwise, if the release branch or main do exist, then UPDATE_BRANCH is set to the release branch or main & the changelog file is updated directly on either of those branches
There was a problem hiding this comment.
Got it... Check 864c905
germa89
commented
Oct 4, 2024
RobPasMue
requested changes
Oct 4, 2024
| @@ -262,7 +262,7 @@ runs: | |||
| if [ $count -gt 0 ]; then | |||
| echo "Using ${{ env.UPDATE_BRANCH }} to update the CHANGELOG file" | |||
| if [[ ${{ env.RELEASE_BRANCH_EXISTS }} == "false" ]]; then | |||
| git checkout -b ${{ env.UPDATE_BRANCH }} | |||
| git checkout -b ${{ env.UPDATE_BRANCH }} ${{ env.UPDATE_BRANCH }} | |||
There was a problem hiding this comment.
Suggested change
| git checkout -b ${{ env.UPDATE_BRANCH }} ${{ env.UPDATE_BRANCH }} | |
| git checkout -b ${{ env.UPDATE_BRANCH }} |
I think we do not need to duplicate it... right?
|
Closing this since there would be no changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.
Close #597