-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI release does not fail when it already exists. #671
Comments
Side-questCan we have something that checks whether the tag and the (I can do the implementation) |
If you are using the trusted publisher approach there are many flags we could consider exposing for this purpose. Using the twine PAT approach to upload in combination with these flags would also be possible but we would have to handle it ourselves I believe. Doable in any case - I like the idea of letting projects decide whether they want to prevent re-upload or not. |
That is a good idea. |
I am not sure that Maybe, we could add a checker for this. To ensure that the versions in the tag and in the package agree. |
So... yesterday I tried to do a "quick" release (disclaimer, it is never quick on PyMAPDL).
And I forgot to update the
pyproject.toml
to the new version (yeeeeahhh.. I know...), however the tag was correct. Hence I had tag withv0.69.2
and thepyproject.toml
withv0.69.1
.Surprisingly, the CICD didn't fail, hence I didn't realise (thanks @greschd for letting me know).
Shouldn't the workflow fail? It is showing a warning though.
One could argue that it is ok in case you want to attach new files after the release is done. Is this something we want to support??
Reference: https://github.com/ansys/pymapdl/actions/runs/12891417279/job/35962119607#step:3:994
The text was updated successfully, but these errors were encountered: