Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML with inline CSS have wrong color for closing quote #18

Closed
5 tasks done
octref opened this issue Jan 26, 2023 · 0 comments
Closed
5 tasks done

HTML with inline CSS have wrong color for closing quote #18

octref opened this issue Jan 26, 2023 · 0 comments

Comments

@octref
Copy link
Contributor

octref commented Jan 26, 2023

Describe the bug

image

image

Related: shikijs/shiki#316

Generally, source shouldn't be set so it falls back to the default color per https://macromates.com/manual/en/language_grammars

Reproduction

Red content

in Vitesse Dark theme

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1
    Memory: 138.23 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.18.1 - ~/.nvm/versions/node/v16.18.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.18.1/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v16.18.1/bin/npm
  Browsers:
    Chrome: 109.0.5414.87
    Safari: 16.2

Used Package Manager

npm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
octref added a commit to octref/vscode-theme-vitesse that referenced this issue Jan 26, 2023
@antfu antfu closed this as completed in c5da3ac Jan 27, 2023
lliei0x pushed a commit to lliei0x-x/vscode-theme-vitesse that referenced this issue Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant