Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating PHPUnit configuration for PHPUnit ^9.3 #13

Open
peter279k opened this issue Aug 28, 2020 · 1 comment
Open

Migrating PHPUnit configuration for PHPUnit ^9.3 #13

peter279k opened this issue Aug 28, 2020 · 1 comment
Assignees
Labels
question Further information is requested
Milestone

Comments

@peter279k
Copy link
Member

When running the composer test, the PHPUnit reports following message:

PHPUnit 9.3.8 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

....... 

After running the vendor/bin/phpunit --migrate-configuration, the phpunit.xml.dist file has been changed and the diff is as follows:

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index a038996..76dce4e 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -1,17 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
-         bootstrap="vendor/autoload.php"
-         colors="true">
-    <testsuites>
-        <testsuite name="Antidot\\Tests">
-            <directory>./test</directory>
-        </testsuite>
-    </testsuites>
-
-    <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
-            <directory suffix=".php">./src</directory>
-        </whitelist>
-    </filter>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true">
+  <coverage processUncoveredFiles="true">
+    <include>
+      <directory suffix=".php">./src</directory>
+    </include>
+  </coverage>
+  <testsuites>
+    <testsuite name="Antidot\\Tests">
+      <directory>./test</directory>
+    </testsuite>
+  </testsuites>
 </phpunit>

Should we consider migrating new PHPUnit configuration?

@peter279k peter279k added the question Further information is requested label Aug 28, 2020
@kpicaza
Copy link
Member

kpicaza commented Aug 28, 2020

Yes, I applied it to some other packages but not to all, don't worry about that, I will fix in the next release of each package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants