Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic hash algorithm support #39

Open
sinui0 opened this issue Jul 30, 2024 · 1 comment
Open

Dynamic hash algorithm support #39

sinui0 opened this issue Jul 30, 2024 · 1 comment

Comments

@sinui0
Copy link

sinui0 commented Jul 30, 2024

Hi, we're currently enjoying using this crate in our project. However, we're now looking to allow users to provide their own hash algorithms which are plugged in with dynamic dispatch. The Hasher trait is intended to be implemented on ZSTs, thus has no access to runtime information.

From the look of it changing Hasher to receive &self would be a relatively large change, although it may be possible to avoid breaking changes by adding new traits and further encapsulating some of the inner functionality. I'll just start with posing this issue, what do you think? I can contribute to this effort if desired.

@themighty1
Copy link
Contributor

This feature has been implemented in a fork https://github.com/tlsnotary/rs-merkle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants