From ca8e0ee8a36bf3278f65e3d714d75ec70ea9e05b Mon Sep 17 00:00:00 2001 From: Devesh chouhan <132684997+devc007@users.noreply.github.com> Date: Sat, 25 Jan 2025 03:44:49 +0530 Subject: [PATCH] Skip TestFQDNCacheMinTTL if cluster has Windows Nodes (#6913) The TestFQDNCacheMinTTL e2e test currently does not support Windows. We skip it if any Node in the test cluster is a Windows Node, which is also consistent with other AntreaPolicy e2e tests. Fixes #6891 Signed-off-by: devesh --- test/e2e/antreapolicy_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/e2e/antreapolicy_test.go b/test/e2e/antreapolicy_test.go index c86ddc2910d..5f4eca551d4 100644 --- a/test/e2e/antreapolicy_test.go +++ b/test/e2e/antreapolicy_test.go @@ -5303,6 +5303,12 @@ func testAntreaClusterNetworkPolicyStats(t *testing.T, data *TestData) { // by TestFQDNCacheMinTTL with 2 fqdnCacheMinTTL values where `0` represents a default value // when fqdnCacheMinTTL is unset . func TestFQDNCacheMinTTL(t *testing.T) { + skipIfAntreaPolicyDisabled(t) + skipIfHasWindowsNodes(t) + skipIfNotIPv4Cluster(t) + skipIfIPv6Cluster(t) + skipIfNotRequired(t, "mode-irrelevant") + t.Run("minTTLUnset", func(t *testing.T) { testWithFQDNCacheMinTTL(t, 0) }) t.Run("minTTL20s", func(t *testing.T) { testWithFQDNCacheMinTTL(t, 20) }) } @@ -5314,11 +5320,6 @@ func testWithFQDNCacheMinTTL(t *testing.T, fqdnCacheMinTTL int) { dnsTTL = 5 ) - skipIfAntreaPolicyDisabled(t) - skipIfNotIPv4Cluster(t) - skipIfIPv6Cluster(t) - skipIfNotRequired(t, "mode-irrelevant") - data, err := setupTest(t) if err != nil { t.Fatalf("Error when setting up test: %v", err)