Fix JSON::Deserialize not working with column_name field #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
COLUMNS
key for declaring instance variables, which is assigned as follows:clear/src/clear/model/modules/has_columns.cr
Line 174 in 3bdaa44
The key is assigned to the method name,
name.var
by default but will be re-assigned tocolumn_name.id
if declared, which is the name of the column in the database, not the name of the method.We need to use the method name and not the column_name, hence the change from
{{name.id}}
to{{settings["crystal_variable_name"]}}
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
bin/ameba
ran without alert.