[SOL] Allocate call arguments on a fixed stack object #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
reviewed
Jan 26, 2024
LucasSte
force-pushed
the
fix-stack-bug
branch
from
bbc7386 to
f481447
Compare
dmakarov
reviewed
Jan 26, 2024
dmakarov
reviewed
Jan 29, 2024
dmakarov
approved these changes
Jan 29, 2024
|
When merging, please use the 'squash and merge' option to reduce the number of commits we need to consider in the future updates from the upstream. |
LucasSte
merged commit 7a686ea
into
anza-xyz:solana-rustc/16.0-2023-06-05
14 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
LucasSte
added a commit
that referenced
this pull request
Feb 16, 2024
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
LucasSte
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dynamic stack frames are enabled, we cannot allocate call arguments on the stack framed based on the old 4096 bytes offset, so a new solution is needed for such a case.
As we cannot know the stack size during code generation, and we cannot read the stack pointer register R11 (the SBF verifier does not allow it), we allocate fixed stack objects on the start of the caller frame and read them via the R5 register in the callee.