Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anmn_temp_gridded_product.py - Use nominal depth when no depth available #763

Open
ggalibert opened this issue Oct 16, 2017 · 8 comments
Open
Labels

Comments

@ggalibert
Copy link
Contributor

Sometimes it is not possible to compute any DEPTH variable for a dataset that contains valuable TEMP data. In this case the script should be able to consider NOMINAL_DEPTH instead.

@mhidas
Copy link
Contributor

mhidas commented Oct 16, 2017

Is that a good idea? It may be ok if you're just looking at a single timeseries and you keep in mind that the depth is only nominal, i.e. at times it may be totally off!

However, if you then combine the temperatures from this instrument into a gridded product where some input values are "placed" in the grid based on nominal depths, while others using measured depths, you may introduce artifacts that are hard to identify and hard to flag as being potentially wrong.

@bpasquer
Copy link
Contributor

That's why originally these data were excluded. But additional checks can be made to ensure that the product for this deployments is consistently using temperature at nominal depth.

@ggalibert
Copy link
Contributor Author

This is just to be able to accept a deployment that doesn't have any P sensor on the mooring. Nominal depth is better than nothing and best we can say. Still better than having no gridded data available in my opinion.

The vertical accuracy lost with using nominal depth might be negligeable/comparable to the vertical bin size?

As soon as there is at least 1 P sensor, there should be an inferred DEPTH for any other instrument.

@mhidas
Copy link
Contributor

mhidas commented Oct 17, 2017

👍 It would be good to include some of this information in the output file's metadata so that the user has some idea about the expected accuracy of the depth values.

@lbesnard
Copy link
Contributor

lbesnard commented May 2, 2019

I guess we can close this now @ggalibert

@ggalibert
Copy link
Contributor Author

Not yet, let's keep of record of this for now.

@lbesnard lbesnard removed their assignment Jun 11, 2019
@ocehugo
Copy link
Contributor

ocehugo commented Nov 3, 2020

Code deprecated, close!? @ggalibert @lbesnard

@lbesnard
Copy link
Contributor

lbesnard commented Nov 3, 2020

I'd love to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants