Avoid use of flatbuffers::size_prefixed_root #7109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
force-pushed
the
7058-avoid-use-of-size_prefixed_root
branch
2 times, most recently
from
d689e17 to
c225a02
Compare
bkietz
force-pushed
the
7058-avoid-use-of-size_prefixed_root
branch
from
c225a02 to
f9e091b
Compare
|
The change looks good to me, I've tested in in https://github.com/XiangpengHao/liquid-cache, and it indeed fixes the problem it tries to fix. cc @alamb |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7058
Rationale for this change
flatbuffers::size_prefixed_root does not seem to do what was originally expected. Replacing it with more explicit code for handling an encapsulated message prefix seems to resolve the case of interest.
What changes are included in this PR?
Usage of
size_prefixed_root( there was only one call, introduced in #2586 ) is replaced with manual prefixed length wrangling. A unit test is addedAre there any user-facing changes?
No
Maybe the error messages?