Extract date parts out of intervals #7189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delamarch3
commented
Feb 27, 2025
| @@ -488,25 +492,31 @@ impl ExtractDatePartExt for PrimitiveArray<IntervalMonthDayNanoType> { | |||
| fn date_part(&self, part: DatePart) -> Result<Int32Array, ArrowError> { | |||
| match part { | |||
| DatePart::Year => Ok(self.unary_opt(|d: IntervalMonthDayNano| Some(d.months / 12))), | |||
| DatePart::Month => Ok(self.unary_opt(|d: IntervalMonthDayNano| Some(d.months))), | |||
| DatePart::Month => Ok(self.unary_opt(|d: IntervalMonthDayNano| Some(d.months % 12))), | |||
There was a problem hiding this comment.
D SELECT datepart('year', interval '12 month');
┌────────────────────────────────────────────────┐
│ datepart('year', CAST('12 month' AS INTERVAL)) │
│ int64 │
├────────────────────────────────────────────────┤
│ 1 │
└────────────────────────────────────────────────┘
D SELECT datepart('month', interval '12 month');
┌─────────────────────────────────────────────────┐
│ datepart('month', CAST('12 month' AS INTERVAL)) │
│ int64 │
├─────────────────────────────────────────────────┤
│ 0 │
└─────────────────────────────────────────────────┘| } | ||
| DatePart::Nanosecond => { | ||
| Ok(self.unary_opt(|d| (d.milliseconds % (60 * 1_000)).checked_mul(1_000_000))) | ||
| } |
There was a problem hiding this comment.
D SELECT datepart('m', interval '1m 61s 33ms 44us');
┌─────────────────────────────────────────────────────┐
│ datepart('m', CAST('1m 61s 33ms 44us' AS INTERVAL)) │
│ int64 │
├─────────────────────────────────────────────────────┤
│ 2 │
└─────────────────────────────────────────────────────┘
D SELECT datepart('s', interval '1m 61s 33ms 44us');
┌─────────────────────────────────────────────────────┐
│ datepart('s', CAST('1m 61s 33ms 44us' AS INTERVAL)) │
│ int64 │
├─────────────────────────────────────────────────────┤
│ 1 │
└─────────────────────────────────────────────────────┘
D SELECT datepart('ms', interval '1m 61s 33ms 44us');
┌──────────────────────────────────────────────────────┐
│ datepart('ms', CAST('1m 61s 33ms 44us' AS INTERVAL)) │
│ int64 │
├──────────────────────────────────────────────────────┤
│ 1033 │
└──────────────────────────────────────────────────────┘
D SELECT datepart('us', interval '1m 61s 33ms 44us');
┌──────────────────────────────────────────────────────┐
│ datepart('us', CAST('1m 61s 33ms 44us' AS INTERVAL)) │
│ int64 │
├──────────────────────────────────────────────────────┤
│ 1033044 │
│ (1.03 million) │
└──────────────────────────────────────────────────────┘| @@ -464,11 +464,15 @@ impl ExtractDatePartExt for PrimitiveArray<IntervalDayTimeType> { | |||
| DatePart::Week => Ok(self.unary_opt(|d| Some(d.days / 7))), | |||
| DatePart::Day => Ok(self.unary_opt(|d| Some(d.days))), | |||
| DatePart::Hour => Ok(self.unary_opt(|d| Some(d.milliseconds / (60 * 60 * 1_000)))), | |||
There was a problem hiding this comment.
D SELECT datepart('hour', interval '25 hour');
┌───────────────────────────────────────────────┐
│ datepart('hour', CAST('25 hour' AS INTERVAL)) │
│ int64 │
├───────────────────────────────────────────────┤
│ 25 │
└───────────────────────────────────────────────┘
D SELECT datepart('day', interval '25 hour');
┌──────────────────────────────────────────────┐
│ datepart('day', CAST('25 hour' AS INTERVAL)) │
│ int64 │
├──────────────────────────────────────────────┤
│ 0 │
└──────────────────────────────────────────────┘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7182
Rationale for this change
date_partwith an interval returns results inconsistent with implementations in duckdb and postgres.What changes are included in this PR?
Parts are excluded from the interval:
Milliseconds, microseconds and nanoseconds will exclude the minutes and hours from the date part, but not seconds, so
date_part('ms', interval '61s')will return 1000Seconds will exclude minutes and hours, so
date_part('s', interval '3600s')will return 0Hours will not exclude days, so
date_part('h', interval '25h')returns 25Months will exclude years, so
date_part('month', interval '13 months')returns 1Are there any user-facing changes?
Yes,
date_partwithIntervalDayTimeTypeandIntervalMonthDayNanoTypewill return a different result