Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Week in Comet (Jan 26) #1342

Open
andygrove opened this issue Jan 26, 2025 · 0 comments
Open

This Week in Comet (Jan 26) #1342

andygrove opened this issue Jan 26, 2025 · 0 comments
Assignees

Comments

@andygrove
Copy link
Member

andygrove commented Jan 26, 2025

Introduction

These notes reflect things I am personally involved in or thinking about and may not cover all activities. Feel free to add comments for anything that I missed.

Previous week's issue: #1305

comet-parquet-exec

The proof-of-concept work for adding new native_datafusion and native_iceberg_compat implementations of the Parquet scan has now been merged into the main branch. These implementations can be enabled via the new COMET_NATIVE_SCAN_IMPL configuration setting and are disabled by default because they are not yet complete.

The focus now is on getting all existing tests to pass with these new scans enabled. Then, we can move on to adding tests for reading complex types (arrays, structs, maps) from Parquet files.

Improving type-checking and test coverage

An initial PR was merged, which refactored QueryPlanSerde.scala to move some inner methods to top-level methods, making them accessible from unit tests, thus making it easier to write unit tests per expression.

There is a follow-up draft PR to improve test coverage for array expressions. Feedback on the approach is welcome before this is extended to improve tests for all other expressions.

Array expressions

There are several PRs ready for review for adding more array expressions.

Upgrade to DataFusion 45

There is a draft PR to prepare to upgrade to DataFusion 45.

@andygrove andygrove pinned this issue Jan 28, 2025
@andygrove andygrove self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant