-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate datetime documentation to code #12966
Migrate datetime documentation to code #12966
Conversation
LGTM, honestly the with_standard_argument isn't a necessary change, just enforces consistency. |
@jonathanc-n But it is changing the meaning of the sentence
So, I am not going with the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing -- thank you @jatin510 🙏
- [date_trunc](#date_trunc) | ||
- [datetrunc](#datetrunc) | ||
- [date_part](#date_part) | ||
- [datepart](#datepart) | ||
- [extract](#extract) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is extract
a special function? I think it might be as it has special syntax
…-docs-for-datetime-functions-to-code
I merged up from main to resolve some conflicts with this PR |
.with_standard_argument('expression', None) is used for when it is just 'expression' at the beginning. In the example you showed that would be with_standard_argument("expression", Some("time")) |
@jatin510 Oh, sorry about the confusion there, i got confused, the commit hasn't been pushed yet. |
Thanks again @jatin510 and @jonathanc-n -- sorry we can't merge these PRs faster. It is all we can do to keep up with reviews these days :) |
Which issue does this PR close?
Closes #12859
Closes #.
Rationale for this change
Documentation migration
What changes are included in this PR?
Documentation related changes for datetime functions.
Are these changes tested?
Yes.
Are there any user-facing changes?