You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the code in datafusion is updated (for example to new sqlogictest versions) the modified driver program may not work with the new sqlogictest version
The modified driver program may not work with new versions of sqllogictest
This happened with #14824 which made it hard to update the expected output
Describe the solution you'd like
I would like to make sure that regenerate_sqlite_files.sh will always work and will not bitrot over time
That is exactly what I was thinking and hopefully will fix tonight. I think a decent short-term fix is to 'lock' the sqllogictest-rs dependency version and add a comment that any update to it will require a full run of the regenerate script before committing.
Long term ideally would be to improve my changes to my fork of sqllogictest-rs such that they would be suitable to submit a PR to that project. That is not an insignificant amount of work to be honest and I'm a bit thin on time for the next month or two.
Describe alternatives you've considered
No response
Additional context
See last time we had to update the scripts based on changes:
Is your feature request related to a problem or challenge?
Thanks to some great work from @Omega359 as part of each commit to main DataFusion runs many thousand queries from the sqlite test suite ❤
This is documented here:
datafusion/datafusion/sqllogictest/README.md
Lines 218 to 252 in d47f7fb
When expected output changes (for example, error messages) we currently use a script https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/regenerate_sqlite_files.sh that:
This is problematic because
This happened with #14824 which made it hard to update the expected output
Describe the solution you'd like
I would like to make sure that
regenerate_sqlite_files.sh
will always work and will not bitrot over time@Omega359 says:
Describe alternatives you've considered
No response
Additional context
See last time we had to update the scripts based on changes:
The text was updated successfully, but these errors were encountered: