We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EquivalenceProperties
https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/equivalence/properties.rs
It is hard to navigate and find what is going on
I would like to split properties.rs into separate modules.
Something like
datafusion/physical-expr/src/equivalence/properties.rs
into
datafusion/physical-expr/src/equivalence/properties/mod.rs. # contains EquivalencePropertes datafusion/physical-expr/src/equivalence/properties/dependencies.rs. # contains `DependencyMap` and `Dependencies` datafusion/physical-expr/src/equivalence/properties/joins.rs. # contains join_equivalence_properties datafusion/physical-expr/src/equivalence/properties/union.rs. # contains calculate_union ... # any others that are needed
And move the relevant tests into the correct module
I think this is a pretty mechanical change so flagging it as a good first issue
The text was updated successfully, but these errors were encountered:
Hi @alamb, I'm interested in this issue, Could you assign it with me?
Sorry, something went wrong.
@Standing-Man You can comment 'take' and it will automatically assign it to you
'take'
Standing-Man
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge?
EquivalenceProperties
#14821 I noticed that propertes.rs is over 4000 lines of rust and has multiple structures in ithttps://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/equivalence/properties.rs
It is hard to navigate and find what is going on
Describe the solution you'd like
I would like to split properties.rs into separate modules.
Describe alternatives you've considered
Something like
into
And move the relevant tests into the correct module
Additional context
I think this is a pretty mechanical change so flagging it as a good first issue
The text was updated successfully, but these errors were encountered: