Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split properties.rs into smaller modules #14913

Closed
alamb opened this issue Feb 27, 2025 · 3 comments · Fixed by #14925
Closed

Split properties.rs into smaller modules #14913

alamb opened this issue Feb 27, 2025 · 3 comments · Fixed by #14925
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Feb 27, 2025

Is your feature request related to a problem or challenge?

https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/equivalence/properties.rs

It is hard to navigate and find what is going on

Describe the solution you'd like

I would like to split properties.rs into separate modules.

Describe alternatives you've considered

Something like

datafusion/physical-expr/src/equivalence/properties.rs

into

datafusion/physical-expr/src/equivalence/properties/mod.rs. # contains EquivalencePropertes
datafusion/physical-expr/src/equivalence/properties/dependencies.rs. # contains `DependencyMap` and `Dependencies`
datafusion/physical-expr/src/equivalence/properties/joins.rs. # contains join_equivalence_properties
datafusion/physical-expr/src/equivalence/properties/union.rs. # contains calculate_union
... # any others that are needed

And move the relevant tests into the correct module

Additional context

I think this is a pretty mechanical change so flagging it as a good first issue

@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels Feb 27, 2025
@Standing-Man
Copy link
Contributor

Hi @alamb, I'm interested in this issue, Could you assign it with me?

@jonathanc-n
Copy link
Contributor

@Standing-Man You can comment 'take' and it will automatically assign it to you

@Standing-Man
Copy link
Contributor

Standing-Man commented Feb 28, 2025

'take'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants