Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change in 46: count_all() expr_fn function now displayed as count(1) rather than count(*) #14894

Open
Tracked by #14123
alamb opened this issue Feb 26, 2025 · 2 comments · May be fixed by #14927
Open
Tracked by #14123

Change in 46: count_all() expr_fn function now displayed as count(1) rather than count(*) #14894

alamb opened this issue Feb 26, 2025 · 2 comments · May be fixed by #14927
Assignees
@jayzhan211
Labels
bug Something isn't working regression Something that used to work no longer does

Comments

@alamb
Copy link
Contributor

alamb commented Feb 26, 2025

This is fallout from #14824

There is a small change in behavior now from DataFusion 45 and DataFusion 46

There were several tests changed (see link below)

In order to preserve behavior from the old version, perhaps we should change count_all() to return count(1) as "count(*)" so it would be consistent with older versions?

Originally posted by @alamb in #14824 (comment)
This was referenced Feb 26, 2025
Open
Merged
@alamb
Copy link
Contributor Author

alamb commented Feb 26, 2025 •
edited
Loading

Since there is a proposed fix in #14824 (comment)

Maybe someone can apply the fix and update the tests ?

@alamb alamb added bug Something isn't working good first issue Good for newcomers regression Something that used to work no longer does labels Feb 26, 2025
@jayzhan211
Copy link
Contributor

I think this is quite different from #14895

@jayzhan211 jayzhan211 self-assigned this Feb 28, 2025
@jayzhan211 jayzhan211 removed the good first issue Good for newcomers label Feb 28, 2025
@jayzhan211 jayzhan211 linked a pull request Feb 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayzhan211 jayzhan211

Labels
bug Something isn't working regression Something that used to work no longer does
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Count wildcard alias jayzhan211/datafusion
2 participants
@alamb @jayzhan211