Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to SessionStateBuilder that has all the defaut features #14981

Open
alamb opened this issue Mar 3, 2025 · 2 comments · May be fixed by #14998
Open

Add method to SessionStateBuilder that has all the defaut features #14981

alamb opened this issue Mar 3, 2025 · 2 comments · May be fixed by #14998
Assignees

Comments

@alamb
Copy link
Contributor

alamb commented Mar 3, 2025

          > Thank you @irenjj -- I think this makes a lot of sense to me

I just wonder if we should provide with_default_features or Default::default implementation for this case as well? wdyt @alamb ?

@milenkovicm I think the usecase of not automatically registering all the default features is to allow creating a SessionState without the defaults (e.g. if you don't want to defaults).

Since there is no method like SessionStateBuilder::clear I am not sure how else one would accomplish this usecase 🤔

than makes sense, what I suggest is to keep all (new) methods as they are just provide new method which will create new with defaults. but I don't have strong opinion about it

Originally posted by @milenkovicm in #14935 (comment)

@alamb
Copy link
Contributor Author

alamb commented Mar 3, 2025

My suggestion here is something like:

  1. Add SessionStateBuilder::new_with_defaults()
  2. Document that it adds the same stuff as with_defaults
  3. Add a doc example

@shruti2522
Copy link

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants