From 30e8de925feecfb7cf2e88da962500ea5a06c3fb Mon Sep 17 00:00:00 2001
From: wyxxxcat <wangyixuan@selectdb.com>
Date: Sun, 19 Jan 2025 14:02:54 +0800
Subject: [PATCH] 1

---
 .../doris/catalog/ListPartitionInfo.java      |  6 +++
 .../test_list_partition_invalid_add.groovy    | 39 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 regression-test/suites/partition_p0/list_partition/test_list_partition_invalid_add.groovy

diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionInfo.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionInfo.java
index 9d6fb63b26954b..44d387e137ba36 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionInfo.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionInfo.java
@@ -83,6 +83,12 @@ public PartitionItem createAndCheckPartitionItem(SinglePartitionDesc desc, boole
 
         // we might receive one whole empty values list, we should add default partition value for
         // such occasion
+
+        if (partitionKeyDesc.getInValues() == null) {
+            throw new DdlException(
+                    "Partitions types is invalid, expected In in list partitions");
+        }
+
         for (List<PartitionValue> values : partitionKeyDesc.getInValues()) {
             if (values.isEmpty()) {
                 continue;
diff --git a/regression-test/suites/partition_p0/list_partition/test_list_partition_invalid_add.groovy b/regression-test/suites/partition_p0/list_partition/test_list_partition_invalid_add.groovy
new file mode 100644
index 00000000000000..39730bf86041a2
--- /dev/null
+++ b/regression-test/suites/partition_p0/list_partition/test_list_partition_invalid_add.groovy
@@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_list_partition_invalid_add") {
+    sql "drop table if exists list_partition_invalid_add_tbl"
+    sql """
+        CREATE TABLE IF NOT EXISTS list_partition_invalid_add_tbl (
+            k1 int NOT NULL, 
+            k2 bigint NOT NULL
+        ) 
+        PARTITION BY LIST(k1,k2) () 
+        DISTRIBUTED BY HASH(k1) BUCKETS 5 properties("replication_num" = "1")
+        """
+
+	test{
+        sql """ alter table list_partition_invalid_add_tbl add partition p0 values [("0"), ("2")) """
+        exception "Partitions types is invalid, expected In in list partitions"
+	}
+
+    sql """ alter table list_partition_invalid_add_tbl add partition p0 values in (("0", "2")) """
+
+    def res = sql_return_maparray """ show partitions from list_partition_invalid_add_tbl where PartitionName = "p0" """
+
+    assertEquals(res[0].Range, "[types: [INT, BIGINT]; keys: [0, 2]; ]")
+}