Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](BE) make MutableBlock's to_block only accept rvalue #47176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

It's good for coding behaviors. use rvalue will make coder cleaner to know it's moved.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32434 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f7f0c1ef5816901db1ff359f9c38709beafb8f7, data reload: false

------ Round 1 ----------------------------------
q1	17602	5541	5392	5392
q2	2058	297	165	165
q3	10433	1282	724	724
q4	10228	974	524	524
q5	7571	2433	2216	2216
q6	194	168	134	134
q7	926	764	614	614
q8	9230	1394	1147	1147
q9	5386	4986	4976	4976
q10	6831	2360	1896	1896
q11	464	278	260	260
q12	343	352	223	223
q13	17800	3707	3090	3090
q14	226	242	210	210
q15	528	477	478	477
q16	624	620	599	599
q17	566	878	318	318
q18	7483	6466	6487	6466
q19	2174	973	529	529
q20	310	325	183	183
q21	2841	2216	1980	1980
q22	360	329	311	311
Total cold run time: 104178 ms
Total hot run time: 32434 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5533	5527	5491	5491
q2	238	332	234	234
q3	2262	2670	2344	2344
q4	1384	1821	1342	1342
q5	4324	4775	4722	4722
q6	181	166	130	130
q7	2052	1977	1831	1831
q8	2682	2799	2732	2732
q9	7323	7318	7208	7208
q10	2981	3304	2842	2842
q11	596	506	506	506
q12	653	760	592	592
q13	3499	3808	3293	3293
q14	292	302	276	276
q15	529	482	477	477
q16	675	662	647	647
q17	1225	1764	1265	1265
q18	7752	7429	7376	7376
q19	790	1184	1092	1092
q20	2035	2045	1886	1886
q21	5715	5190	5018	5018
q22	598	569	556	556
Total cold run time: 53319 ms
Total hot run time: 51860 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f7f0c1ef5816901db1ff359f9c38709beafb8f7, data reload: false

query1	978	391	389	389
query2	6519	2051	1998	1998
query3	6789	220	215	215
query4	33475	23100	23006	23006
query5	4299	594	438	438
query6	270	204	180	180
query7	4609	474	316	316
query8	276	234	223	223
query9	9575	2564	2569	2564
query10	471	311	250	250
query11	18071	15165	14935	14935
query12	155	105	106	105
query13	1656	525	411	411
query14	10230	6908	6981	6908
query15	229	197	193	193
query16	8007	589	492	492
query17	1620	750	572	572
query18	2068	406	309	309
query19	227	202	165	165
query20	163	107	110	107
query21	207	121	99	99
query22	4289	4495	4169	4169
query23	34114	32816	33214	32816
query24	6448	2232	2291	2232
query25	499	448	375	375
query26	1196	273	152	152
query27	1988	455	320	320
query28	5416	2405	2384	2384
query29	710	564	430	430
query30	232	185	156	156
query31	962	855	804	804
query32	85	62	56	56
query33	524	359	274	274
query34	746	838	494	494
query35	789	843	737	737
query36	992	1018	938	938
query37	118	99	75	75
query38	4193	4160	4138	4138
query39	1425	1406	1415	1406
query40	209	118	110	110
query41	52	52	53	52
query42	125	102	104	102
query43	503	523	485	485
query44	1248	788	799	788
query45	174	170	165	165
query46	850	1056	631	631
query47	1829	1814	1804	1804
query48	388	386	313	313
query49	780	481	400	400
query50	654	652	393	393
query51	6796	7033	6890	6890
query52	98	100	94	94
query53	226	254	185	185
query54	486	494	413	413
query55	81	79	81	79
query56	251	265	238	238
query57	1161	1128	1106	1106
query58	250	233	242	233
query59	3050	3167	2830	2830
query60	278	273	249	249
query61	116	113	120	113
query62	800	687	662	662
query63	222	192	182	182
query64	4446	1020	656	656
query65	3255	3125	3192	3125
query66	1056	452	313	313
query67	15924	15675	15438	15438
query68	4572	825	525	525
query69	470	293	257	257
query70	1185	1146	1109	1109
query71	373	289	296	289
query72	5923	3840	3782	3782
query73	645	754	363	363
query74	10150	9109	8921	8921
query75	3166	3190	2661	2661
query76	3192	1187	761	761
query77	468	353	274	274
query78	10008	9889	9368	9368
query79	3070	823	588	588
query80	668	524	425	425
query81	512	273	234	234
query82	453	150	128	128
query83	169	175	159	159
query84	247	93	72	72
query85	778	412	313	313
query86	397	307	306	306
query87	4387	4492	4469	4469
query88	4902	2140	2114	2114
query89	380	323	293	293
query90	1852	191	190	190
query91	134	134	108	108
query92	73	58	57	57
query93	2379	892	525	525
query94	706	409	306	306
query95	334	320	262	262
query96	484	615	283	283
query97	2740	2893	2762	2762
query98	230	212	194	194
query99	1270	1366	1246	1246
Total cold run time: 286245 ms
Total hot run time: 187224 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6f7f0c1ef5816901db1ff359f9c38709beafb8f7, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.06
query4	1.64	0.10	0.10
query5	0.42	0.44	0.42
query6	1.17	0.66	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.52	0.50
query10	0.56	0.57	0.56
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.61	0.61	0.60
query14	2.83	2.82	2.74
query15	0.89	0.84	0.84
query16	0.38	0.40	0.38
query17	1.00	1.04	1.01
query18	0.23	0.21	0.21
query19	1.87	1.83	1.98
query20	0.01	0.01	0.01
query21	15.36	0.89	0.59
query22	0.76	0.76	0.73
query23	15.25	1.43	0.56
query24	3.33	1.82	1.54
query25	0.20	0.10	0.21
query26	0.25	0.14	0.14
query27	0.04	0.05	0.06
query28	13.83	0.99	0.45
query29	12.58	3.92	3.27
query30	0.25	0.08	0.06
query31	2.85	0.62	0.40
query32	3.22	0.55	0.47
query33	3.12	2.99	3.00
query34	16.82	5.12	4.49
query35	4.52	4.45	4.57
query36	0.65	0.50	0.48
query37	0.09	0.06	0.05
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.41 s
Total hot run time: 31.3 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 41.52% (10821/26061)
Line Coverage: 31.92% (91432/286482)
Region Coverage: 31.07% (46853/150794)
Branch Coverage: 27.16% (23730/87358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6f7f0c1ef5816901db1ff359f9c38709beafb8f7_6f7f0c1ef5816901db1ff359f9c38709beafb8f7/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants