Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [opt](storage vault) Check s3.root.path cannot be empty #47078 #47196

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47078

@github-actions github-actions bot requested a review from dataroaring as a code owner January 18, 2025 17:49
@Thearas
Copy link
Contributor

Thearas commented Jan 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 18, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 18, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40743 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34d06d7a7d58308a4490bb76700bdc858d624b7c, data reload: false

------ Round 1 ----------------------------------
q1	17585	7380	7192	7192
q2	2062	172	169	169
q3	10725	1065	1214	1065
q4	10574	744	721	721
q5	7761	2823	2796	2796
q6	239	146	146	146
q7	1000	609	603	603
q8	9351	1969	2021	1969
q9	6600	6365	6364	6364
q10	7061	2291	2333	2291
q11	474	274	273	273
q12	402	217	214	214
q13	17822	2977	3040	2977
q14	241	207	212	207
q15	575	523	527	523
q16	716	610	598	598
q17	964	552	549	549
q18	7302	6732	6746	6732
q19	1410	1106	1097	1097
q20	467	209	196	196
q21	4040	3087	3299	3087
q22	1063	974	991	974
Total cold run time: 108434 ms
Total hot run time: 40743 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7204	7212	7183	7183
q2	322	232	229	229
q3	2880	2943	2949	2943
q4	2074	1860	1874	1860
q5	5767	5760	5708	5708
q6	225	139	146	139
q7	2323	1825	1857	1825
q8	3336	3582	3513	3513
q9	8804	8881	8824	8824
q10	3554	3521	3520	3520
q11	589	507	489	489
q12	830	623	605	605
q13	9268	3191	3154	3154
q14	309	273	265	265
q15	569	512	528	512
q16	715	675	671	671
q17	1837	1624	1606	1606
q18	8268	7807	7806	7806
q19	1648	1532	1609	1532
q20	2116	1876	1877	1876
q21	5523	5392	5403	5392
q22	1138	1051	1022	1022
Total cold run time: 69299 ms
Total hot run time: 60674 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198111 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34d06d7a7d58308a4490bb76700bdc858d624b7c, data reload: false

query1	1314	917	913	913
query2	6208	2114	2012	2012
query3	10777	4268	4385	4268
query4	66286	28934	23680	23680
query5	4964	445	433	433
query6	403	160	166	160
query7	5584	314	311	311
query8	294	225	228	225
query9	8976	2664	2666	2664
query10	460	274	261	261
query11	17486	15359	15893	15359
query12	158	110	106	106
query13	1534	433	422	422
query14	10886	8352	7498	7498
query15	208	188	186	186
query16	7110	477	499	477
query17	1078	594	598	594
query18	1200	332	329	329
query19	201	161	190	161
query20	119	107	110	107
query21	218	108	105	105
query22	4697	4622	4442	4442
query23	34847	34366	34337	34337
query24	6090	2877	2979	2877
query25	551	417	425	417
query26	658	177	172	172
query27	1953	353	354	353
query28	4608	2459	2454	2454
query29	713	483	489	483
query30	246	161	161	161
query31	1005	844	846	844
query32	69	60	56	56
query33	475	287	270	270
query34	913	506	524	506
query35	870	732	756	732
query36	1092	949	971	949
query37	125	71	75	71
query38	4166	4025	4021	4021
query39	1520	1499	1463	1463
query40	226	100	97	97
query41	49	47	49	47
query42	112	97	102	97
query43	538	492	507	492
query44	1222	830	811	811
query45	187	170	167	167
query46	1161	749	718	718
query47	1991	1919	1940	1919
query48	478	380	376	376
query49	731	399	382	382
query50	846	417	421	417
query51	7370	7207	7125	7125
query52	95	88	91	88
query53	263	179	181	179
query54	558	454	460	454
query55	77	77	76	76
query56	261	244	251	244
query57	1218	1142	1100	1100
query58	218	223	214	214
query59	2994	2870	2981	2870
query60	282	255	248	248
query61	112	110	108	108
query62	772	668	661	661
query63	218	183	187	183
query64	1389	694	656	656
query65	3243	3189	3168	3168
query66	642	319	295	295
query67	15952	15559	15606	15559
query68	4031	590	566	566
query69	427	266	270	266
query70	1175	1138	1114	1114
query71	326	249	251	249
query72	6371	3947	4058	3947
query73	757	349	354	349
query74	10160	8937	9088	8937
query75	3353	2651	2632	2632
query76	1909	1048	974	974
query77	501	301	292	292
query78	10653	9620	9625	9620
query79	1548	598	597	597
query80	887	427	444	427
query81	521	246	241	241
query82	1257	121	112	112
query83	252	150	143	143
query84	284	81	82	81
query85	900	317	290	290
query86	340	294	307	294
query87	4505	4295	4365	4295
query88	3834	2400	2361	2361
query89	421	286	287	286
query90	1996	186	188	186
query91	181	146	150	146
query92	64	49	49	49
query93	1875	547	546	546
query94	788	304	309	304
query95	353	253	254	253
query96	615	281	293	281
query97	3408	3219	3167	3167
query98	216	204	191	191
query99	1586	1301	1285	1285
Total cold run time: 318761 ms
Total hot run time: 198111 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34d06d7a7d58308a4490bb76700bdc858d624b7c, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.54	0.52	0.53
query6	1.12	0.74	0.73
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.57	0.50	0.50
query10	0.55	0.55	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.13
query13	0.60	0.60	0.60
query14	2.89	2.96	3.05
query15	0.89	0.81	0.82
query16	0.38	0.39	0.38
query17	1.04	1.06	1.07
query18	0.23	0.22	0.21
query19	1.90	1.85	1.96
query20	0.01	0.01	0.01
query21	15.36	0.61	0.56
query22	2.48	2.61	1.38
query23	16.88	0.83	0.94
query24	3.17	1.06	1.15
query25	0.15	0.10	0.06
query26	0.61	0.14	0.14
query27	0.05	0.04	0.04
query28	10.28	1.11	1.07
query29	12.57	3.30	3.32
query30	0.24	0.06	0.06
query31	2.86	0.40	0.38
query32	3.25	0.46	0.45
query33	2.98	3.00	3.07
query34	17.29	4.47	4.49
query35	4.56	4.53	4.47
query36	0.67	0.52	0.52
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.89 s
Total hot run time: 32.77 s

@dataroaring dataroaring merged commit 089ef91 into branch-3.0 Jan 19, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-47078-branch-3.0 branch January 19, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants