Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Style] Can we use .editorconfig to format the codes and ignore the order of imported class? #2594

Open
LINGLUOJUN opened this issue Aug 24, 2024 · 4 comments
Labels
question Further information is requested

Comments

@LINGLUOJUN
Copy link
Contributor

LINGLUOJUN commented Aug 24, 2024

Question

Since almost all of us use idea as a tool in our daily development, so I think it's importance for us to support a unify . format file by .editorconfig that can be imported by idea and more easy to format our codes.
Another one is that can we ignore the order of imported class? In my oppion,it's no need to care about that

@LINGLUOJUN LINGLUOJUN added the question Further information is requested label Aug 24, 2024
@LINGLUOJUN LINGLUOJUN changed the title [Code Style] Can we use .editorconfig to format the codes? [Code Style] Can we use .editorconfig to format the codes and ignore the order of imported class? Aug 24, 2024
@tomsun28
Copy link
Contributor

Another one is that can we ignore the order of imported class? In my oppion,it's no need to care about that

how about this, @crossoverJie the default import order of idea is different from what we configured. I met several developers who asked about the related errors and they could only adjust it manually.

@tomsun28
Copy link
Contributor

Can we use .editorconfig to format the codes and ignore the order of imported class

hi, @LINGLUOJUN of course, the fronted wep-app has used the .editorconfig, we can add one in backend.

@crossoverJie
Copy link
Member

Another one is that can we ignore the order of imported class? In my oppion,it's no need to care about that

how about this, @crossoverJie the default import order of idea is different from what we configured. I met several developers who asked about the related errors and they could only adjust it manually.

Yes, some developers have also been asking me about this issue. I think maybe we should temporarily disable the import order check and enable it later once HertzBeat is stable.

@tomsun28
Copy link
Contributor

Yes, some developers have also been asking me about this issue. I think maybe we should temporarily disable the import order check and enable it later once HertzBeat is stable.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants