reactor: refactor the code that does not comply with license requirements #7145
+52
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7145 +/- ##
============================================
+ Coverage 51.77% 52.24% +0.46%
- Complexity 6754 6798 +44
============================================
Files 1151 1151
Lines 40970 40982 +12
Branches 4803 4803
============================================
+ Hits 21213 21410 +197
+ Misses 17762 17543 -219
- Partials 1995 2029 +34
|
ptyin
requested changes
Feb 10, 2025
|
|
||
| return res; | ||
| //Return the final alternative result, or all if result has not changed | ||
| return result == null || result === obj ? all : result; |
There was a problem hiding this comment.
I think it should be ${res == null || res === obj ? all : res} to convert res to string if necessary.
slievrly
changed the title
1 task
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
refactor some code
Ⅱ. Does this pull request fix one issue?
https://lists.apache.org/thread/wbq6jsykj2cd9nn91ys1b8r99bfl1h2r
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews