Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryExecDatasetBuilder.timeout uses micros instead of millis. #2960

Closed
Aklakan opened this issue Jan 19, 2025 · 0 comments · Fixed by #2961
Closed

QueryExecDatasetBuilder.timeout uses micros instead of millis. #2960

Aklakan opened this issue Jan 19, 2025 · 0 comments · Fixed by #2961
Labels

Comments

@Aklakan
Copy link
Contributor

Aklakan commented Jan 19, 2025

Version

5.3.0-SNAPSHOT

What happened?

While updating my code to latest changes I came across a minor but potentially annoying slip up 6e8b170#diff-1e7b0bc46f44905f474449b163261e11be2447457b09ca16c7525616ea073eaeR167

    @Override
    public QueryExecDatasetBuilder timeout(long timeout) {
        return timeout(timeout, TimeUnit.MICROSECONDS); // should be millis
    }

Relevant output and stacktrace

Are you interested in making a pull request?

Yes

@Aklakan Aklakan added the bug label Jan 19, 2025
Aklakan added a commit to Aklakan/jena that referenced this issue Jan 19, 2025
@Aklakan Aklakan changed the title QueryExecDataset.timeout uses Microseconds instead of Millis QueryExecDatasetBuilder.timeout uses micros instead of millis. Jan 19, 2025
@afs afs closed this as completed in #2961 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant