HDDS-12086. Allow --db option at leaf subcommand in debug tools #7710
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarvekshayr @Tejaskriya please take a look |
sarvekshayr
approved these changes
Jan 16, 2025
Tejaskriya
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thanks for making this change @adoroszlai. This usage is easier, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently
--dbis accepted only directly afterldb, before any subcommand name or options. The goal of this PR is to improve usability by allowing--dbafter subcommand or even after other options.https://issues.apache.org/jira/browse/HDDS-12086
How was this patch tested?
Updated integration test to cover three different positions of the option.
CI:
https://github.com/adoroszlai/ozone/actions/runs/12807326607