[Feature] skywalking as a platform and multi tenant

[chenhaipeng]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

I want to use skywalking as a platform and use tenant id to isolate the data of each business. My solution is to use receiver-sharing-server.authentication to identify the data of different businesses and increase the storage ID. I don’t know how other people deal with it . Does the community have a recommended solution?

Use case

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

Hi, multiple tenants concept is a project level thing. It should be very serious.
What you proposed is too simple to uncover a lot of things. We need a complete proposal if you are going to work on this.

1. What is the definition of tenant.
2. How and where define a tenant? Such as is there management feature for it?
3. If the data is out of SkyWalking native agent, how to define it.
4. How tenant affects the storage data and formats.
5. Which isolation level among tenants. This is very important, we may face a lot of potential CVE reports due to tenant boundary breaking is a serious issue.
6. How UI works with this new concept? Do you or anyone one on your team promise to implement quickly, nd cover maintainance in the future?
7. How our export, alerting, MAL, OAL, LAL work with tenant concept?

This is a simple version of FAQs if you want to deeply dive into this topic.

[wu-sheng]

If you ask how SkyWalking did, it is no such concept.

[chenhaipeng]

UI -> UI-proxy ->RABC -> GraphQL

[chenhaipeng]

en, This is a destructive function，I modified AuthenticationInterceptor.java to inject tenantId,
I modified AuthenticationInterceptor.java to inject tenantId. In fact, this class does not do this.

That is a naive change, only surviving in your private use case. SkyWalking has dozens of data sources, what you proposed at agent side is actually not working from my perspective.

And trust a client ID without decoding is a common security issue.

The client ID is just a token, you can sign the clientId, Skywalking OAP receives the clientId, whether to trust or decode it is another question

[wu-sheng]

UI -> UI-proxy ->RABC -> GraphQL

If RABC is not in OAP directly accessing, this could be another CVE

This is what I mean it is a big change.

If you want to do, let's do based on an official doc(google doc) with all details. Why, how to change, how to verify, security check list, 3rd party ecosystem status(breaking?)

You need to be very detail very careful. And every breaking decision you made may bring you -1 for voting.

[chenhaipeng]

UI -> UI-proxy ->RABC -> GraphQL

If RABC is not in OAP directly accessing, this could be another CVE

This is what I mean it is a big change.

If you want to do, let's do based on an official doc(google doc) with all details. Why, how to change, how to verify, security check list, 3rd party ecosystem status(breaking?)

You need to be very detail very careful. And every breaking decision you made may bring you -1 for voting.

Yes, at present, only a small number of appeals require this feature to be used as a platform. Let’s discuss the necessity first.

[wu-sheng]

For me, I don't know either. Tenancy is always a hot topic.

[chenhaipeng]

I have simply implemented the function of distinguishing tenants. If the community needs this feature, I am happy to help submit it

[Superskyyy]

AFAIK, there have been many users asking for this feature, but still gotta be very careful as this generally is a easy place to get dozens of CVEs.