Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-5376 Fix BOM leaking unrelated dependencies #1234

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Feb 25, 2025

WW-5376

There's a few ways of achieving this, the key criteria being that the struts2-bom artifact does not inherit any dependencyManagement entries.

The solution I've chosen follows this hierarchy:
struts2-project -> struts2-bom -> struts2-parent -> all other modules

This is in contrast to the previous state:
struts2-parent -> struts2-bom and all other modules

@kusalk kusalk force-pushed the WW-5376-bom-fix branch 6 times, most recently from 4c08863 to 730d5ae Compare February 25, 2025 08:29
Base automatically changed from WW-5532-upg-deps to main February 25, 2025 08:34
@kusalk kusalk marked this pull request as ready for review February 25, 2025 08:36
Copy link

@kusalk kusalk requested a review from lukaszlenart February 25, 2025 08:37
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I get it right that users should import struts2-bom to get all the needed dependencies?

@kusalk
Copy link
Member Author

kusalk commented Feb 25, 2025

Do I get it right that users should import struts2-bom to get all the needed dependencies?

That's correct, users should continue using the existing Struts BOM coordinates, no changes are required on their end. All the unrelated dependencies will no longer be included in the BOM after this change is merged.

@kusalk
Copy link
Member Author

kusalk commented Feb 25, 2025

Going forth, we should NOT put any dependencies in the root POM (struts2-project - /pom.xml).
We put only Struts artifacts in the BOM POM (struts2-bom - /bom/pom.xml).
And any other dependencies should be defined in the "parent" POM (struts2-parent - /parent/pom.xml).

@kusalk kusalk merged commit 2ab0a3c into main Feb 25, 2025
8 checks passed
@kusalk kusalk deleted the WW-5376-bom-fix branch February 25, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants