Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support ops-def list and describe #484

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Nov 11, 2024

what's changed?

support kbcli ops-definition/ops-def list/ls and kbcli ops-definition/ops-def describe/desc
image
image
image

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 11, 2024
@yipeng1030 yipeng1030 changed the title feat: support ops-def list and describe chore: support ops-def list and describe Nov 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.75127% with 164 lines in your changes missing coverage. Please review.

Project coverage is 41.44%. Comparing base (509f77e) to head (b1fcf65).

Files with missing lines Patch % Lines
pkg/cmd/opsdefinition/describe.go 7.31% 151 Missing and 1 partial ⚠️
pkg/cmd/opsdefinition/opsdefinition.go 80.00% 4 Missing and 1 partial ⚠️
pkg/cmd/componentversion/describe.go 0.00% 4 Missing ⚠️
pkg/cmd/componentdefinition/describe.go 0.00% 2 Missing ⚠️
pkg/cmd/clusterdefinition/describe.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
- Coverage   41.63%   41.44%   -0.20%     
==========================================
  Files         171      173       +2     
  Lines       23431    23621     +190     
==========================================
+ Hits         9756     9789      +33     
- Misses      12552    12707     +155     
- Partials     1123     1125       +2     
Flag Coverage Δ
unittests 41.44% <16.75%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 merged commit 0db1ed3 into main Nov 11, 2024
15 checks passed
@yipeng1030 yipeng1030 deleted the feature/support_ops_ls_and_desc branch November 11, 2024 10:18
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants