Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters need post-update hooks #179

Open
hugary1995 opened this issue Dec 10, 2024 · 0 comments
Open

parameters need post-update hooks #179

hugary1995 opened this issue Dec 10, 2024 · 0 comments

Comments

@hugary1995
Copy link
Collaborator

When we update model parameters, some intermediate tensors that depend on the updated parameters should be updated as well. So in theory, whenever the parameters are updated, those intermediate tensors should be recalculated.

However, we don't want to calculate the intermediate tensors in the forward operator itself, as that potentially repeats a fair of computation. Ideally, we want models to register post-update hooks for parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant