From 37c83f580ae08d92e2adde72c6565fa969f5b8ef Mon Sep 17 00:00:00 2001 From: nowakweronika Date: Tue, 12 Mar 2024 10:34:31 +0100 Subject: [PATCH] Change name of "success" param to "action_success". --- .../loudius/AbsPullRequestsScreenTest.kt | 2 +- .../loudius/AbsReviewersScreenTest.kt | 10 +++--- .../loudius/UniversalWalkThroughAppTest.kt | 10 +++--- .../analytics/events/AuthenticatingEvents.kt | 8 ++--- .../analytics/events/PullRequestsEvents.kt | 8 ++--- .../analytics/events/ReviewersEvents.kt | 12 +++---- docs/event_details/action_finished.md | 4 +-- docs/screens/authenticating.md | 16 ++++----- docs/screens/pullrequests_screen.md | 24 ++++++------- docs/screens/reviewers_screen.md | 36 +++++++++---------- 10 files changed, 65 insertions(+), 65 deletions(-) diff --git a/app-shared-tests/src/main/java/com/appunite/loudius/AbsPullRequestsScreenTest.kt b/app-shared-tests/src/main/java/com/appunite/loudius/AbsPullRequestsScreenTest.kt index 0f57ca4d..9e539369 100644 --- a/app-shared-tests/src/main/java/com/appunite/loudius/AbsPullRequestsScreenTest.kt +++ b/app-shared-tests/src/main/java/com/appunite/loudius/AbsPullRequestsScreenTest.kt @@ -65,7 +65,7 @@ abstract class AbsPullRequestsScreenTest { expectThat(analyticsRule.analytics.log).containsExactly( AnalyticsLog("action_start", mapOf("item_name" to "fetch_pull_requests_data", "screen_name" to "pull_requests_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "pull_requests_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "fetch_pull_requests_data", "success" to true, "screen_name" to "pull_requests_screen")) + AnalyticsLog("action_finished", mapOf("item_name" to "fetch_pull_requests_data", "action_success" to true, "screen_name" to "pull_requests_screen")) ) } } diff --git a/app-shared-tests/src/main/java/com/appunite/loudius/AbsReviewersScreenTest.kt b/app-shared-tests/src/main/java/com/appunite/loudius/AbsReviewersScreenTest.kt index 8c4e0abc..d68b20af 100644 --- a/app-shared-tests/src/main/java/com/appunite/loudius/AbsReviewersScreenTest.kt +++ b/app-shared-tests/src/main/java/com/appunite/loudius/AbsReviewersScreenTest.kt @@ -68,7 +68,7 @@ abstract class AbsReviewersScreenTest { expectThat(analyticsRule.analytics.log).containsExactly( AnalyticsLog("action_start", mapOf("item_name" to "fetch_reviewers_data", "screen_name" to "reviewers_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "success" to true, "screen_name" to "reviewers_screen")) + AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "action_success" to true, "screen_name" to "reviewers_screen")) ) } } @@ -100,10 +100,10 @@ abstract class AbsReviewersScreenTest { expectThat(analyticsRule.analytics.log).containsExactly( AnalyticsLog("action_start", mapOf("item_name" to "fetch_reviewers_data", "screen_name" to "reviewers_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "success" to true, "screen_name" to "reviewers_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "action_success" to true, "screen_name" to "reviewers_screen")), AnalyticsLog("button_click", mapOf("item_name" to "notify", "screen_name" to "reviewers_screen")), AnalyticsLog("action_start", mapOf("item_name" to "notify", "screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "notify", "success" to true, "screen_name" to "reviewers_screen")) + AnalyticsLog("action_finished", mapOf("item_name" to "notify", "action_success" to true, "screen_name" to "reviewers_screen")) ) } } @@ -132,10 +132,10 @@ abstract class AbsReviewersScreenTest { expectThat(analyticsRule.analytics.log).containsExactly( AnalyticsLog("action_start", mapOf("item_name" to "fetch_reviewers_data", "screen_name" to "reviewers_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "success" to true, "screen_name" to "reviewers_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "action_success" to true, "screen_name" to "reviewers_screen")), AnalyticsLog("button_click", mapOf("item_name" to "notify", "screen_name" to "reviewers_screen")), AnalyticsLog("action_start", mapOf("item_name" to "notify", "screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "notify", "success" to false, "screen_name" to "reviewers_screen", "error_message" to "Client request(POST https://api.github.com/repos/exampleOwner/exampleRepo/issues/1/comments) invalid: 404 Client Error. Text: \"\"")) + AnalyticsLog("action_finished", mapOf("item_name" to "notify", "action_success" to false, "screen_name" to "reviewers_screen", "error_message" to "Client request(POST https://api.github.com/repos/exampleOwner/exampleRepo/issues/1/comments) invalid: 404 Client Error. Text: \"\"")) ) } } diff --git a/app-shared-tests/src/main/java/com/appunite/loudius/UniversalWalkThroughAppTest.kt b/app-shared-tests/src/main/java/com/appunite/loudius/UniversalWalkThroughAppTest.kt index 420f8062..47ca395d 100644 --- a/app-shared-tests/src/main/java/com/appunite/loudius/UniversalWalkThroughAppTest.kt +++ b/app-shared-tests/src/main/java/com/appunite/loudius/UniversalWalkThroughAppTest.kt @@ -68,18 +68,18 @@ abstract class UniversalWalkThroughAppTest { AnalyticsLog("action_start", mapOf("item_name" to "authentication", "screen_name" to "authenticating_screen")), AnalyticsLog("action_start", mapOf("item_name" to "get_access_token", "screen_name" to "authenticating_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "authenticating_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "get_access_token", "success" to true, "screen_name" to "authenticating_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "authentication", "success" to true, "screen_name" to "authenticating_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "get_access_token", "action_success" to true, "screen_name" to "authenticating_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "authentication", "action_success" to true, "screen_name" to "authenticating_screen")), AnalyticsLog("action_start", mapOf("item_name" to "fetch_pull_requests_data", "screen_name" to "pull_requests_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "pull_requests_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "fetch_pull_requests_data", "success" to true, "screen_name" to "pull_requests_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "fetch_pull_requests_data", "action_success" to true, "screen_name" to "pull_requests_screen")), AnalyticsLog("item_click", mapOf("item_name" to "pull_request", "screen_name" to "pull_requests_screen")), AnalyticsLog("action_start", mapOf("item_name" to "fetch_reviewers_data", "screen_name" to "reviewers_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "success" to true, "screen_name" to "reviewers_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "fetch_reviewers_data", "action_success" to true, "screen_name" to "reviewers_screen")), AnalyticsLog("button_click", mapOf("item_name" to "notify", "screen_name" to "reviewers_screen")), AnalyticsLog("action_start", mapOf("item_name" to "notify", "screen_name" to "reviewers_screen")), - AnalyticsLog("action_finished", mapOf("item_name" to "notify", "success" to true, "screen_name" to "reviewers_screen")), + AnalyticsLog("action_finished", mapOf("item_name" to "notify", "action_success" to true, "screen_name" to "reviewers_screen")), AnalyticsLog("screen_opened", mapOf("screen_name" to "pull_requests_screen")) ) } diff --git a/app/src/main/java/com/appunite/loudius/analytics/events/AuthenticatingEvents.kt b/app/src/main/java/com/appunite/loudius/analytics/events/AuthenticatingEvents.kt index d2fb855d..6b2d1718 100644 --- a/app/src/main/java/com/appunite/loudius/analytics/events/AuthenticatingEvents.kt +++ b/app/src/main/java/com/appunite/loudius/analytics/events/AuthenticatingEvents.kt @@ -41,7 +41,7 @@ object AuthenticatingEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "authentication"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "authenticating_screen") ) } @@ -50,7 +50,7 @@ object AuthenticatingEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "authentication"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "authenticating_screen"), EventParameter.String("error_message", errorMessage) ) @@ -68,7 +68,7 @@ object AuthenticatingEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "get_access_token"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "authenticating_screen") ) } @@ -77,7 +77,7 @@ object AuthenticatingEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "get_access_token"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "authenticating_screen"), EventParameter.String("error_message", errorMessage) ) diff --git a/app/src/main/java/com/appunite/loudius/analytics/events/PullRequestsEvents.kt b/app/src/main/java/com/appunite/loudius/analytics/events/PullRequestsEvents.kt index 365303a3..7a6e6add 100644 --- a/app/src/main/java/com/appunite/loudius/analytics/events/PullRequestsEvents.kt +++ b/app/src/main/java/com/appunite/loudius/analytics/events/PullRequestsEvents.kt @@ -42,7 +42,7 @@ object PullRequestsEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "refresh_pull_requests_data"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "pull_requests_screen") ) } @@ -51,7 +51,7 @@ object PullRequestsEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "refresh_pull_requests_data"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "pull_requests_screen"), EventParameter.String("error_message", errorMessage) ) @@ -69,7 +69,7 @@ object PullRequestsEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "fetch_pull_requests_data"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "pull_requests_screen") ) } @@ -78,7 +78,7 @@ object PullRequestsEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "fetch_pull_requests_data"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "pull_requests_screen"), EventParameter.String("error_message", errorMessage) ) diff --git a/app/src/main/java/com/appunite/loudius/analytics/events/ReviewersEvents.kt b/app/src/main/java/com/appunite/loudius/analytics/events/ReviewersEvents.kt index 7987e8f7..34d59a0e 100644 --- a/app/src/main/java/com/appunite/loudius/analytics/events/ReviewersEvents.kt +++ b/app/src/main/java/com/appunite/loudius/analytics/events/ReviewersEvents.kt @@ -50,7 +50,7 @@ object ReviewersEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "notify"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "reviewers_screen") ) } @@ -59,7 +59,7 @@ object ReviewersEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "notify"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "reviewers_screen"), EventParameter.String("error_message", errorMessage) ) @@ -77,7 +77,7 @@ object ReviewersEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "refresh_reviewers_data"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "reviewers_screen") ) } @@ -86,7 +86,7 @@ object ReviewersEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "refresh_reviewers_data"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "reviewers_screen"), EventParameter.String("error_message", errorMessage) ) @@ -104,7 +104,7 @@ object ReviewersEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "fetch_reviewers_data"), - EventParameter.Boolean("success", true), + EventParameter.Boolean("action_success", true), EventParameter.String("screen_name", "reviewers_screen") ) } @@ -113,7 +113,7 @@ object ReviewersEvents { override val name: String = "action_finished" override val parameters: List = listOf( EventParameter.String("item_name", "fetch_reviewers_data"), - EventParameter.Boolean("success", false), + EventParameter.Boolean("action_success", false), EventParameter.String("screen_name", "reviewers_screen"), EventParameter.String("error_message", errorMessage) ) diff --git a/docs/event_details/action_finished.md b/docs/event_details/action_finished.md index 1dedb768..f3f24bf1 100644 --- a/docs/event_details/action_finished.md +++ b/docs/event_details/action_finished.md @@ -18,7 +18,7 @@ Called when the [action_start](action_start.md) is finished. { "event_name": "action_finished", "item_name": "Downloading User Profile", - "success": true, + "action_success": true, "screen_name": "reviewers_screen" } ``` @@ -29,7 +29,7 @@ or { "event_name": "action_finished", "item_name": "Downloading User Profile", - "success": false, + "action_success": false, "screen_name": "reviewers_screen", "error_message": "Some error message." } diff --git a/docs/screens/authenticating.md b/docs/screens/authenticating.md index aa40ffe3..dc4ec52f 100644 --- a/docs/screens/authenticating.md +++ b/docs/screens/authenticating.md @@ -11,17 +11,17 @@ | After user clicks log in, authentication started. |
{
"name": "action_start"
"item_name": "authentication"
"screen_name": "authenticating_screen"
}
 |
 |:-------------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------|
 
-| When application gets access token and authentication finished with success. | 
{
"name": "action_finished"
"item_name": "authentication"
"success": true
"screen_name": "authenticating_screen"
}
 |
-|:----------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| When application gets access token and authentication finished with success. | 
{
"name": "action_finished"
"item_name": "authentication"
"action_success": true
"screen_name": "authenticating_screen"
}
 |
+|:----------------------------------------------------------------------------:|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 
-| When application doesn't get access token and  When authentication finished with failure. | 
{
"name": "action_finished"
"item_name": "authentication"
"success": false
"screen_name": "authenticating_screen"
"error_message": "Some error message."
}
 |
-|:-----------------------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| When application doesn't get access token and  When authentication finished with failure. | 
{
"name": "action_finished"
"item_name": "authentication"
"action_success": false
"screen_name": "authenticating_screen"
"error_message": "Some error message."
}
 |
+|:-----------------------------------------------------------------------------------------:|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 
 | When get access token started. | 
{
"name": "action_start"
"item_name": "get_access_token"
"screen_name": "authenticating_screen"
}
 |
 |:------------------------------:|-------------------------------------------------------------------------------------------------------------------------------------------|
 
-| When get access token finished with success. | 
{
"name": "action_finished"
"item_name": "get_access_token"
"success": true
"screen_name": "authenticating_screen"
}
 |
-|:--------------------------------------------:|----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| When get access token finished with success. | 
{
"name": "action_finished"
"item_name": "get_access_token"
"action_success": true
"screen_name": "authenticating_screen"
}
 |
+|:--------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 
-| When get access token finished with failure. | 
{
"name": "action_finished"
"item_name": "get_access_token"
"success": false
"screen_name": "authenticating_screen"
"error_message": "Some error message."
}}
 |
-|:--------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| When get access token finished with failure. | 
{
"name": "action_finished"
"item_name": "get_access_token"
"action_success": false
"screen_name": "authenticating_screen"
"error_message": "Some error message."
}}
 |
+|:--------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
diff --git a/docs/screens/pullrequests_screen.md b/docs/screens/pullrequests_screen.md
index 207668e4..c957f398 100644
--- a/docs/screens/pullrequests_screen.md
+++ b/docs/screens/pullrequests_screen.md
@@ -12,25 +12,25 @@
 |:--------------------------------------------------------------------------------:|----------------------------------------------------------------------------------------------------------------------------------------------------|
 |  | 
{
"name": "action_start"
"item_name": "refresh_pull_requests_data"
"screen_name": "pull_requests_screen"
}
 |
 
-|                         When refresh data finished with success.                         | Specification                                                                                                                                                                |
-|:----------------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "refresh_pull_requests_data"
"success": true
}
 |
+|                         When refresh data finished with success.                         | Specification                                                                                                                                                                       |
+|:----------------------------------------------------------------------------------------:|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "refresh_pull_requests_data"
"action_success": true
}
 |
 
-|                         When refresh data finished with failure.                         | Specification                                                                                                                                                                                                                 |
-|:----------------------------------------------------------------------------------------:|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "refresh_pull_requests_data"
"success": false
"screen_name": "pull_requests_screen"
"error_message": "Some error message."
}
 |
+|                         When refresh data finished with failure.                         | Specification                                                                                                                                                                                                                        |
+|:----------------------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "refresh_pull_requests_data"
"action_success": false
"screen_name": "pull_requests_screen"
"error_message": "Some error message."
}
 |
 
 |                         When fetching data is started.                         | Specification                                                                                                                                    |
 |:------------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------------|
 |  | 
{
"name": "action_start"
"item_name": "fetch_pull_requests_data"
"screen_name": "pull_requests_screen"
}
 |
 
-|                         When fetch data finished with success.                         | Specification                                                                                                                                                               |
-|:--------------------------------------------------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "fetch_pull_requests_data"
"success": true
"screen_name": "pull_requests_screen"
}
 |
+|                         When fetch data finished with success.                         | Specification                                                                                                                                                                      |
+|:--------------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "fetch_pull_requests_data"
"action_success": true
"screen_name": "pull_requests_screen"
}
 |
 
-|                         When fetch data finished with failure.                         | Specification                                                                                                                                                                                                               |
-|:--------------------------------------------------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "fetch_pull_requests_data"
"success": false
"screen_name": "pull_requests_screen"
"error_message": "Some error message."
}
 |
+|                         When fetch data finished with failure.                         | Specification                                                                                                                                                                                                                      |
+|:--------------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "fetch_pull_requests_data"
"action_success": false
"screen_name": "pull_requests_screen"
"error_message": "Some error message."
}
 |
 
 |                           When user clicks on pull request item.                           | Specification                                                                                                                      |
 |:------------------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------|
diff --git a/docs/screens/reviewers_screen.md b/docs/screens/reviewers_screen.md
index 17ce64ee..d7cc75b7 100644
--- a/docs/screens/reviewers_screen.md
+++ b/docs/screens/reviewers_screen.md
@@ -16,34 +16,34 @@
 |:--------------------------------------------------------------------------------:|----------------------------------------------------------------------------------------------------------------------------|
 | ![Success after notify](../analytics_imgs/reviewers/when_user_clicks_notify.png) | 
{
"name": "action_start"
"item_name": "notify"
"screen_name": "reviewers_screen"
}
 |
 
-|            After user clicks notify, action finished with success.            | Specification                                                                                                                                         |
-|:-----------------------------------------------------------------------------:|-------------------------------------------------------------------------------------------------------------------------------------------------------|
-| ![Success after notify](../analytics_imgs/reviewers/after_notify_success.png) | 
{
"name": "action_finished"
"item_name": "notify"
"success": true
"screen_name": "reviewers_screen"
}
 |
+|            After user clicks notify, action finished with success.            | Specification                                                                                                                                                |
+|:-----------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| ![Success after notify](../analytics_imgs/reviewers/after_notify_success.png) | 
{
"name": "action_finished"
"item_name": "notify"
"action_success": true
"screen_name": "reviewers_screen"
}
 |
 
-|           After user clicks notify, action finished with error.           | Specification                                                                                                                                                                                         |
-|:-------------------------------------------------------------------------:|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| ![Error after notify](../analytics_imgs/reviewers/after_notify_error.png) | 
{
"name": "action_finished"
"item_name": "notify"
"success": false
"screen_name": "reviewers_screen"
"error_message": "Some error message."
}
 |
+|           After user clicks notify, action finished with error.           | Specification                                                                                                                                                                                                |
+|:-------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| ![Error after notify](../analytics_imgs/reviewers/after_notify_error.png) | 
{
"name": "action_finished"
"item_name": "notify"
"action_success": false
"screen_name": "reviewers_screen"
"error_message": "Some error message."
}
 |
 
 |                           When user pulls to refresh.                            | Specification                                                                                                                              |
 |:--------------------------------------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------|
 |  | 
{
"name": "action_start"
"item_name": "refresh_reviewers_data"
"screen_name": "reviewers_screen"
}
 |
 
-|                       When refresh data finished with success.                        | Specification                                                                                                                                                         |
-|:-------------------------------------------------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "refresh_reviewers_data"
"success": true
"screen_name": "reviewers_screen"
}
 |
+|                       When refresh data finished with success.                        | Specification                                                                                                                                                                |
+|:-------------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "refresh_reviewers_data"
"action_success": true
"screen_name": "reviewers_screen"
}
 |
 
-|                       When refresh data finished with error.                        | Specification                                                                                                                                                                                                         |
-|:-----------------------------------------------------------------------------------:|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "refresh_reviewers_data"
"success": false
"screen_name": "reviewers_screen"
"error_message": "Some error message."
}
 |
+|                       When refresh data finished with error.                        | Specification                                                                                                                                                                                                                |
+|:-----------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "refresh_reviewers_data"
"action_success": false
"screen_name": "reviewers_screen"
"error_message": "Some error message."
}
 |
 
 |                          When fetching data is started.                           | Specification                                                                                                                            |
 |:---------------------------------------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------|
 |  | 
{
"name": "action_start"
"item_name": "fetch_reviewers_data"
"screen_name": "reviewers_screen"
}
 |
 
-|                       When fetch data finished with success.                        | Specification                                                                                                                                                       |
-|:-----------------------------------------------------------------------------------:|---------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "fetch_reviewers_data"
"success": true
"screen_name": "reviewers_screen"
}
 |
+|                       When fetch data finished with success.                        | Specification                                                                                                                                                              |
+|:-----------------------------------------------------------------------------------:|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "fetch_reviewers_data"
"action_success": true
"screen_name": "reviewers_screen"
}
 |
 
-|                       When fetch data finished with error.                        | Specification                                                                                                                                                                                                       |
-|:---------------------------------------------------------------------------------:|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  | 
{
"name": "action_finished"
"item_name": "fetch_reviewers_data"
"success": false
"screen_name": "reviewers_screen"
"error_message": "Some error message."
}
 |
+|                       When fetch data finished with error.                        | Specification                                                                                                                                                                                                              |
+|:---------------------------------------------------------------------------------:|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|  | 
{
"name": "action_finished"
"item_name": "fetch_reviewers_data"
"action_success": false
"screen_name": "reviewers_screen"
"error_message": "Some error message."
}
 |