Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize circuit product algorithm to support products of compatible circuits with different structures #269

Open
loreloc opened this issue Sep 18, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@loreloc
Copy link
Member

loreloc commented Sep 18, 2024

That is, cover the missing cases (see #TODOs in the symbolic product function):

  • product between an input layer and either a sum or product layer
  • product between a sum layer and a product layer
  • product between sum layers of different arity
@loreloc loreloc added bug Something isn't working enhancement New feature or request labels Sep 18, 2024
@arranger1044
Copy link
Member

We should keep the overlapping scopes case around (perhaps in a different issue?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants