Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to guarantee CI tests are always up to date #63

Closed
lkct opened this issue Jun 14, 2023 · 3 comments · Fixed by #76
Closed

Find a way to guarantee CI tests are always up to date #63

lkct opened this issue Jun 14, 2023 · 3 comments · Fixed by #76
Assignees
Labels
repository Related to managing the repository

Comments

@lkct
Copy link
Member

lkct commented Jun 14, 2023

#59 and #58 caused conflicts that were not captured by CI. Also ref the fix: #62.

We should implement some mechanisms to guarantee this will not happen in the future.

@lkct lkct added the repository Related to managing the repository label Jun 14, 2023
@loreloc
Copy link
Member

loreloc commented Jun 15, 2023

Perhaps we can run tests after merging to main too.

@lkct
Copy link
Member Author

lkct commented Jun 22, 2023

"Always suggest updating pull request branches" is now enabled by @arranger1044. This provides a button to update branch if not synced with main.

We consider this issue resolved for now. Follow-up is tracked by #77.

@lkct lkct self-assigned this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository Related to managing the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants