Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): use log instead of fmt for logging #8033

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Dec 3, 2024

Description

This PR fixes logging when a property conversion fails, which could not be suppressed with the quiet flag.

Before:

property of type map cannot be converted to int

After:

2024-12-03T16:25:00+06:00       DEBUG   Failed to convert property      from="map" to="int" range="template.yaml:7-8"

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review December 3, 2024 15:18
@nikpivkin nikpivkin requested a review from simar7 as a code owner December 3, 2024 15:18
@simar7
Copy link
Member

simar7 commented Dec 4, 2024

FYI if CLI gets stuck: https://cla-assistant.io/check/aquasecurity/trivy?pullRequest=8033 we should probably document this somewhere

@simar7 simar7 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into aquasecurity:main with commit 07b2d7f Dec 4, 2024
14 checks passed
@aqua-bot aqua-bot mentioned this pull request Dec 4, 2024
@nikpivkin nikpivkin deleted the cf-log branch December 4, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants