Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve geth dependency #108

Open
facuspagnuolo opened this issue Jul 22, 2019 · 3 comments
Open

Improve geth dependency #108

facuspagnuolo opened this issue Jul 22, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers tests

Comments

@facuspagnuolo
Copy link
Contributor

Current templates are tested with a geth node, mainly used by the CI, using an Aragon's geth-devnet docker image. Tests are run relying on a previous step that basically waits until the gas limit of the node has increased to 8M gas. To avoid waiting time for that, we are committing the ethereum-data dir within the shared sub-repo. This dir will hold all the information related to the geth instance being run, thus files will be changing and git will keep tracking them.

We should improve this flow, either updating our geth image or exploring a painless way to deal with ethereum-data

@facuspagnuolo facuspagnuolo added enhancement New feature or request tests labels Jul 22, 2019
@sohkai
Copy link
Contributor

sohkai commented Jul 22, 2019

Given that all networks are pretty much operating at 8M gas, can we not start geth in the docker image with that much gas?

@facuspagnuolo
Copy link
Contributor Author

facuspagnuolo commented Jul 22, 2019

Yea, that definitely will work, but I'm not sure if we won't break other repos. If we are sure we won't, it should be easy

@bingen
Copy link
Contributor

bingen commented Jul 23, 2019

Given that all networks are pretty much operating at 8M gas, can we not start geth in the docker image with that much gas?

I tried long time ago and it didn't work for me, maybe I was doing something wrong. I don't think it will break anything, so let's give it another try.

@facuspagnuolo facuspagnuolo added the good first issue Good for newcomers label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers tests
Projects
None yet
Development

No branches or pull requests

3 participants