Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph Nodes inexplicably re-ordered on refresh #11651

Open
whatisgalen opened this issue Nov 25, 2024 · 6 comments · May be fixed by #11737
Open

Graph Nodes inexplicably re-ordered on refresh #11651

whatisgalen opened this issue Nov 25, 2024 · 6 comments · May be fixed by #11737
Assignees
@jacobtylerwalls
Labels
Subject: Graph Manager Type: Bug Something isn't working

Comments

@whatisgalen
Copy link
Member

whatisgalen commented Nov 25, 2024 •
edited
Loading

Some new ordering is put in place when you refresh a graph in the graph designer (which is pretty annoying after you've ordered them alphabetically), see screen recording:

Screen.Recording.2024-11-24.at.11.59.55.PM.mov

seen on dev/7.6.x
@chiatt chiatt added this to pipeline Nov 25, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Jan 21, 2025
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Jan 21, 2025
@jacobtylerwalls
Copy link
Member

Picking this one up because it's making harder to test a feature involving node sort order.

@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Jan 21, 2025
jacobtylerwalls added a commit that referenced this issue Jan 21, 2025
@jacobtylerwalls
Fix node reordering #11651
09c8b2e
@jacobtylerwalls jacobtylerwalls linked a pull request Jan 21, 2025 that will close this issue
Open
11 tasks
@jacobtylerwalls
Copy link
Member

Hey @whatisgalen after looking again more closely, I can't reproduce what you show in the video. I can only reproduce a problem if trying to reorder nodes on a published graph, and on 7.6 only. (The API response does not have the correct node orders, so I can at least fix that, will update PR.)

On 7.6 we could consider showing an error message if you attempt a reorder on a published graph, but it was too tricky for me to pull off in knockout.

jacobtylerwalls added a commit that referenced this issue Jan 29, 2025
@jacobtylerwalls
Fix node sortorder in reorder nodes response #11651
0bc247b
@whatisgalen
Copy link
Member Author

@jacobtylerwalls This was on 7.6, I believe it was a brand new, unpublished graph (until I publish as seen in the video).

@jacobtylerwalls
Copy link
Member

Right, I couldn't reproduce with those steps.

@whatisgalen
Copy link
Member Author

Super weird, I am also no longer able to reproduce. Hmmm...

@bferguso
Copy link
Contributor

I am still running into this in 7.6. I'll see if I can reproduce. For me it's when I export the resource model JSON file and reload using python manage.py packages -o load_package -s ./... it doesn't honour the sortorder (and can be seen in the exported JSON file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Subject: Graph Manager Type: Bug Something isn't working
Projects
pipeline
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix node sortorder in reorder nodes API response #11651 archesproject/arches
3 participants
@bferguso @whatisgalen @jacobtylerwalls