Fix querying on related model's I18n_TextField #11800 #11801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Feb 20, 2025
Comment on lines
-66
to
+67
| if (self.value_is_primitive or self.value is None) and not isinstance( | ||
| compiler, SQLInsertCompiler | ||
| if (self.value_is_primitive or self.value is None) and isinstance( | ||
| compiler, SQLUpdateCompiler |
There was a problem hiding this comment.
For a filter() call, this was coming in as just SQLCompiler.
Comment on lines
+22
to
+23
| def test_filter_related_model_i18n_text_field(self): | ||
| self.assertEqual(Node.objects.filter(graph__name__en="Graph Name").count(), 0) |
There was a problem hiding this comment.
The other test classes in this file use custom models, but they didn't have foreign keys set up, so it seemed simpler to just dogfood the real models. Open to changing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Before, queries failed when trying to filter on a related model's I18n_TextField.
Issues Solved
Closes #11800
Checklist