Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile functions catch TypeError too widely #11805

Open
jacobtylerwalls opened this issue Feb 21, 2025 · 0 comments · May be fixed by #11807
Open

Tile functions catch TypeError too widely #11805

jacobtylerwalls opened this issue Feb 21, 2025 · 0 comments · May be fixed by #11807
Assignees
Labels
Type: Bug Something isn't working

Comments

@jacobtylerwalls
Copy link
Member

Any TypeError emitted during a tile function is caught by the caller and logged in such a way that it breaks the loop and causes other functions to not run.

try:
for function in self._getFunctionClassInstances():
try:
function.save(self, request, context=context)
except NotImplementedError:
pass
except TypeError as e:
logger.warning(
_("No associated functions or other TypeError raised by a function")
)
logger.warning(e)

@jacobtylerwalls jacobtylerwalls self-assigned this Feb 21, 2025
@chiatt chiatt added this to pipeline Feb 21, 2025
@jacobtylerwalls jacobtylerwalls added the Type: Bug Something isn't working label Feb 21, 2025
jacobtylerwalls added a commit that referenced this issue Feb 21, 2025
Catching this could cause other functions to not run.
@jacobtylerwalls jacobtylerwalls moved this to 👀 In Review in pipeline Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
Status: 👀 In Review
Development

Successfully merging a pull request may close this issue.

1 participant