TileData.post catches all exceptions inside its transaction

[jacobtylerwalls]

TileData.post looks like it uses a transaction to roll back failed writes, but it actually has no effect since all exceptions are caught inside its context.

Instead, we could let errors propagate and then transform them to a JSON response outside the transaction context manager.

arches/arches/app/views/tile.py

Lines 161 to 190 in 6d065af

	with transaction.atomic():
	try:
	if accepted_provisional is None:
	try:
	tile.save(
	request=request,
	resource_creation=resource_creation,
	transaction_id=transaction_id,
	)
	except TileValidationError as e:
	resource_tiles_exist = (
	models.TileModel.objects.filter(
	resourceinstance=tile.resourceinstance
	).exists()
	)
	if not resource_tiles_exist:
	Resource.objects.get(
	pk=tile.resourceinstance_id
	).delete(request.user)
	title = _(
	"Unable to save. Please verify your input is valid"
	)
	return self.handle_save_error(
	e, tile_id, title=title
	)
	except Exception as e:
	title = _("Unable to save.")
	return self.handle_save_error(
	e, tile_id, title=title, message=str(e)
	)