Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module v2? #25

Open
siretart opened this issue Oct 30, 2024 · 2 comments
Open

module v2? #25

siretart opened this issue Oct 30, 2024 · 2 comments

Comments

@siretart
Copy link

I saw this module was tagged as v2.

Doesn't the line below therefore need to end in /v2 as well?

module github.com/areYouLazy/libhosty

Trying to update downstream project end otherwise in:

$ go get github.com/areYouLazy/libhosty/[email protected]
go: github.com/areYouLazy/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/areYouLazy/libhosty/v2")
@areYouLazy
Copy link
Owner

You seem to be absolutely right!
Also, if I can read it correctly, I should move all the code in a v2/ folder, right?

https://go.dev/blog/v2-go-modules

@siretart
Copy link
Author

siretart commented Nov 6, 2024

That appears correct.

May I ask what's warranting a major version bump? I supposed it is some API change that require code changes in code that uses this library. It would be greatly helpful for consuming packages to have some notes on what's needed to migrate code to the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants