Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing setPreviewView() setter to ModuleController #2723

Open
zachgarwood opened this issue Feb 5, 2025 · 0 comments · May be fixed by #2724
Open

Add missing setPreviewView() setter to ModuleController #2723

zachgarwood opened this issue Feb 5, 2025 · 0 comments · May be fixed by #2724

Comments

@zachgarwood
Copy link
Contributor

zachgarwood commented Feb 5, 2025 •
edited
Loading

Summary

It seems that most properties on ModuleController have setters, making it easy to set properties in the setUpController() method. However, the $previewView property is lacking its own setter.

Describe the solution you'd like

Create a ModuleController::setPreviewView() setter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a ModuleController::setPreviewView() method zachgarwood/twill
1 participant
@zachgarwood