Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: system to better track monkeypatch code changes upstream #621

Open
hi-liang opened this issue Mar 1, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@hi-liang
Copy link
Member

hi-liang commented Mar 1, 2024

We have a number of monkeypatches for components/systems in mostly AFRAME. We need some better system to track upstream changes to specifically these prototype methods/properties, similar to what is expected for #620

Current list:

  • wasd-controls

    • schema
    • init
    • tick
    • updateVelocity
  • nav (aframe-extras/pathfinding)

    • init
    • setNavMeshGeometry
    • getPath
    • getGroup
    • getNode
    • clampStep
  • gltf-model (component)

    • update
    • init
  • hide-on-enter-ar

    • init
  • hide-on-enter-vr

    • init
  • animation-mixer (aframe-extras/loaders)

    • load
  • raycaster

    • init
    • checkIntersections

FWIW I just checked all of these as of today (March 1, 2024) and except 1 minor change in wasd-controls, everything is up to date

hi-liang added a commit that referenced this issue Mar 1, 2024
This was an old upstream update that was missed ~2021
ref #621
@mwfarb mwfarb added the enhancement New feature or request label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants