Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Secret Manager Type can't get secret key If GCP Secret Manager use JSON #689

Open
kingbj940429 opened this issue Jan 24, 2025 · 0 comments

Comments

@kingbj940429
Copy link

kingbj940429 commented Jan 24, 2025

Is your feature request related to a problem? Please describe.
If use GCP Secret Manager, It can't parse json data

example,
I have a GCP Secret Manager named kingbj0429-secret
and kingbj0429-secret has various secrets as json

{
  db-username: admin
  db-password: admin
}

like this situatiom, argo-vault-plugin for GCP Secret Manager can't parse db-password secret

argo-vault-plugin for GCP Secret Manager get all json data itself.

so I can't use secret with GCP

apiVersion: v1
data:
  #-- <path:projects/kingbj0429-447407/secrets/kingbj0429-secret#db-password>
  test: PHBhdGg6cHJvamVjdHMva2luZ2JqMDQyOS00NDc0MDcvc2VjcmV0cy9raW5nYmowNDI5LXNlY3JldCNkYi1wYXNzd29yZD4=
kind: Secret
metadata:
  name: test-secrets
  namespace: arc-system
type: Opaque

Describe the solution you'd like

Image
this is gcpsecretmanager.go's code

It can only use secret manager name as key
json's key can't be key

so I want to add function for parsing json key like awssecretmanager.go's GetSecrets Function
Image

Describe alternatives you've considered
maybe a implement is needed

Additional context
Can I Pull Request this?

I'll code about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant