Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Rollouts with scaleDown and HPA #4110

Open
sedflix opened this issue Feb 5, 2025 · 0 comments
Open

Migrating to Rollouts with scaleDown and HPA #4110

sedflix opened this issue Feb 5, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@sedflix
Copy link

sedflix commented Feb 5, 2025

We have HPA enabled using KEDA and are trying to start using Rollouts by Referencing Deployment From Rollout.

Setup:
The following happens when we try to enable Rollouts with

  • "scaleDown" setting as "onsuccess" or even "progressively".
  • We do not set "replicas" in the Rollout Spec due to this.

When using "progressively":

  • Rollout starts spinning up 1 pod and terminating all the pods(except 1) in the Deployment.
  • HPA fails with the HPA controller was unable to get the target's current scale: rollouts.argoproj.io "<>" not found
  • After some time, HPA successfully triggers a scale operation. Rollout starts creating more pods (and it creates more pods in the Deployment following the scaleDown setting).

When using "onsuccess":

  • Rollout starts spinning up 1 pod
  • HPA fails with the HPA controller was unable to get the target's current scale: rollouts.argoproj.io "<>" not found
  • After 1 pod is started successfully, it scales down all the previous pods. Therefore, we end up having only one 1 pod of the service.
  • After some time, HPA successfully triggers a scale and things start getting back to normal.

Is it possible for the "scaleDown" function to check the health of HPA before triggering any scale-down?

@sedflix sedflix added the enhancement New feature or request label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant